Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HepMC plugin looks incomplete #3050

Open
andiwand opened this issue Mar 22, 2024 · 5 comments
Open

HepMC plugin looks incomplete #3050

andiwand opened this issue Mar 22, 2024 · 5 comments
Labels

Comments

@andiwand
Copy link
Contributor

While working on #2998 I noticed that HepMC plugin is incomplete. It also seems like we are not using or testing the code anywhere in detail.

  • Problem with ownership of Acts particles
    • Currently Acts particles cannot refer to each other and are usually owned by a container holding all particles
    • When introducing vertices this becomes a problem
    • When modeling vertices this becomes a problem
  • Conversion is incomplete
    • The Acts barcode is not properly filled
  • Code is not used
  • Code is not properly tested
@AJPfleger
Copy link
Contributor

@paulgessinger:
The plugin is quite old and was used by @FabianKlimpel in 2018 for testing.
Maybe there was an EDM mismatch, that Fabian tried to work around.
It seems like something useful to have, but needs some work.

Please someone work on it, because it is cool. Maybe @andiwand ?

@andiwand
Copy link
Contributor Author

I fear I won't have time to work on this.

@FabianKlimpel
Copy link
Contributor

I think I just used it for the parametrisation of hadronic interactions in Fatras. So just for a limited scope and period of time. Hence I can imangine that something went out of sync with Acts. If you want to continue using it, I recommend to ping @andriish as he is one of the HepMC developers and helped me out during the development.

@andriish
Copy link
Contributor

Hi, the barcode should be used carefully or should not be used at all. Concerning other things i will be happy to help.

Copy link

This issue/PR has been automatically marked as stale because it has not had recent activity. The stale label will be removed if any interaction occurs.

@github-actions github-actions bot added the Stale label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants