Count the number of holes in the KF #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't we already have the hole count form the CKF? Why do we need to recalculate it in the KF? |
|
I added it because CKF and KF may have different propagation setup (particle hypothesis, navigator config, etc.). The propagation of CKF also stops if the number of holes hit a certain number ( |
beomki-yeo
force-pushed
the
count-holes
branch
from
97ddeae
to
acec9af
Compare
stephenswat
approved these changes
Nov 26, 2024
|
OK I didn't change the propagator algorithm and KF and CKF might yield the same result for the holes. But it is not bad to have the hole counting in KF in case we combine with other track finding methods that don't do any hole counting (e.g. GNN...) |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #774
The number of holes will be required in the ambiguity solver.
To count the number of holes even after all track candidates are visited, the abort condition in the KF is removed. This will increase the CPU computing time but impact on the GPU KF will be much smaller.
Also added a test to make sure the new feature works correctly