Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITk Processing Fixes, main branch (2024.11.22.) #779

Merged

Conversation

krasznaa
Copy link
Member

This is a collection of changes I made to be able to use the files produced by @paradajzblond in the example applications.

  • Had to teach all (relevant) executables to respect the --input-skip and --use-acts-geom-source command line flags;
  • Turned off memory caching for the host-based throughput applications. I just noticed it while debugging an issue (see next bullet point) that we've been unnecessarily using caching with those applications so far. 🤔
  • I had to find that with De-Template (Host) Track Fitting, main branch (2024.10.28.) #756 I introduced a bug into traccc::host::full_chain_algorithm. 😦 (Which would allow the code to access invalid memory.) This PR now fixes that.
    • While debugging that, I also found a minor issue in traccc::host::details::fit_tracks(...), where it would use the default memory resource instead of the explicitly provided one for one of the temporary containers,

With all this in place, I'm able to exercise all the executables on Neza's files. 😄

@krasznaa krasznaa added bug Something isn't working cpu Changes related to CPU code examples Changes to the examples labels Nov 22, 2024
Copy link

sonarcloud bot commented Nov 22, 2024

Copy link
Contributor

@beomki-yeo beomki-yeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable

@stephenswat stephenswat merged commit 6d98265 into acts-project:main Nov 22, 2024
26 checks passed
@krasznaa krasznaa deleted the ITkProcessingFixes-main-20241122 branch November 22, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cpu Changes related to CPU code examples Changes to the examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants