Jagged Proxy Fixes, main branch (2024.09.30.) #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turned out that jagged vector variables were not handled correctly by the code previously. So now I added some tests for such proxied variables, and also greatly simplified how the type traits used by vecmem::edm::proxy would be implemented.
krasznaa
force-pushed
the
JaggedProxyFix-main-20240930
branch
from
6f0c38a
to
626d2a5
Compare
|
It seems to be working well with the traccc code... 🤔 |
stephenswat
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turned out in acts-project/traccc#712 that jagged vector variables were not handled correctly by the code previously. 😦 Preventing me from handling "clusters" with the use of proxy objects in that PR.
So now I added some tests for such proxied variables, and also greatly simplified how the type traits used by
vecmem::edm::proxywould be implemented.