Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sinon-chrome-webextensions.min.js uses the chrome namespace #100

Open
jobara opened this issue May 6, 2020 · 0 comments
Open

sinon-chrome-webextensions.min.js uses the chrome namespace #100

jobara opened this issue May 6, 2020 · 0 comments

Comments

@jobara
Copy link

jobara commented May 6, 2020

When trying to use sinon-chrome-webextension.min.js for unit tests in a web browser, it does not stub the browser namespace but rather the chrome namespace. This requires a workaround in the test to remap the namespace to browser from chrome. Ideally the sinon-chrome-webextension.min.js uses the browser namespace as it's intended to mock those APIs.

I'm not sure if this is the issue, but potentially the problem is related to https://github.com/acvetkov/sinon-chrome/blob/master/webpack.config.js#L34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant