Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chrome.runtime.id should be a non-empty string #104

Open
nickserv opened this issue Sep 2, 2020 · 0 comments
Open

chrome.runtime.id should be a non-empty string #104

nickserv opened this issue Sep 2, 2020 · 0 comments

Comments

@nickserv
Copy link

nickserv commented Sep 2, 2020

Various libraries like webextension-polyfill expect chrome.runtime.id to be a non-empty string. This causes several issues integrating sinon-chrome such as mozilla/webextension-polyfill#236 and #103. While sinon-chrome can't guess the exact id, using something like "testid" (suggested in mozilla/webextension-polyfill#218 (comment)) seems to work pretty well. Alternatively we could use a random string of lowercase letters so it's not a hard coded value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant