-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heather M SeaTurtles js-adagrams #94
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,168 @@ | ||
const letterPool = { | ||
A: 9, | ||
B: 2, | ||
C: 2, | ||
D: 4, | ||
E: 12, | ||
F: 2, | ||
G: 3, | ||
H: 2, | ||
I: 9, | ||
J: 1, | ||
K: 1, | ||
L: 4, | ||
M: 2, | ||
N: 6, | ||
O: 8, | ||
P: 2, | ||
Q: 1, | ||
R: 6, | ||
S: 4, | ||
T: 6, | ||
U: 4, | ||
V: 2, | ||
W: 2, | ||
X: 1, | ||
Y: 2, | ||
Z: 1, | ||
}; | ||
|
||
export const drawLetters = () => { | ||
// Implement this method for wave 1 | ||
// Return a randomized list of ten letters | ||
let allLetters = []; | ||
let tenLetters = []; | ||
// if (letterPool.length === 0) {break}; | ||
// console.log("letterPool: ", letterPool); | ||
for (const [key, value] of Object.entries(letterPool)) { | ||
// console.log("key:", key); | ||
for (let n = 0; n < value; n++) { | ||
allLetters.push(key); | ||
// console.log("key:", key); | ||
} | ||
} | ||
// console.log("allLetters:", allLetters); | ||
let indexie = []; | ||
// let n = 0; | ||
while (indexie.length < 10) { | ||
// n++; | ||
let i = Math.floor(Math.random() * allLetters.length); | ||
// console.log("i: ", i); | ||
if (indexie.includes(i)) { | ||
continue; | ||
} else { | ||
indexie.push(i); | ||
} | ||
} | ||
indexie.forEach((k) => { | ||
return tenLetters.push(allLetters[k]); | ||
}); | ||
// console.log("indexie:", indexie); | ||
// console.log("tenLetters:", tenLetters); | ||
return tenLetters; | ||
}; | ||
|
||
export const usesAvailableLetters = (input, lettersInHand) => { | ||
// Implement this method for wave 2 | ||
// input is a string of letters. | ||
// lettersInHand is an array of letters. | ||
// this seems a bit long. Maybe I can use another method to count letter in ... | ||
// or maybe I can make another function to do this. | ||
const lettersArray = lettersInHand; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I know you were thinking of another way to do this. Here is one way to do it with one for loop export const usesAvailableLetters = (input, lettersInHand) => {
const input_array = input.split("");
const n = input.length;
let lettersInHandCopy = [...lettersInHand];
for (let i = 0; i < n; i++) {
let letter = input_array[i];
if (lettersInHandCopy.includes(letter)) {
let j = lettersInHandCopy.indexOf(letter);
lettersInHandCopy.splice(j, 1);
} else {
return false;
}
}
return true;
}; |
||
for (let letter of input) { | ||
let inputCount = 0; | ||
let handCount = 0; | ||
for (let i = 0; i < input.length; i++) { | ||
if (input[i] === letter) { | ||
inputCount++; | ||
} | ||
} | ||
for (let i = 0; i < lettersInHand.length; i++) { | ||
if (lettersInHand[i] === letter) { | ||
handCount++; | ||
} | ||
} | ||
if (!lettersInHand.includes(letter) || inputCount > handCount) { | ||
return false; | ||
} | ||
} | ||
return true; | ||
}; | ||
|
||
export const scoreWord = (word) => { | ||
// Implement this method for wave 3 | ||
const scoreChart = { | ||
A: 1, | ||
E: 1, | ||
I: 1, | ||
O: 1, | ||
U: 1, | ||
L: 1, | ||
N: 1, | ||
R: 1, | ||
S: 1, | ||
T: 1, | ||
D: 2, | ||
G: 2, | ||
B: 3, | ||
C: 3, | ||
M: 3, | ||
P: 3, | ||
F: 4, | ||
H: 4, | ||
V: 4, | ||
W: 4, | ||
Y: 4, | ||
K: 5, | ||
J: 8, | ||
X: 8, | ||
Q: 10, | ||
Z: 10, | ||
}; | ||
let score = 0; | ||
if (word.length > 0 && typeof word === "string") { | ||
const wordUppercase = word.toUpperCase(); | ||
for (let i = 0; i < wordUppercase.length; i++) { | ||
score += scoreChart[wordUppercase[i]]; | ||
} | ||
if (word.length > 6) { | ||
score += 8; | ||
} | ||
Comment on lines
+128
to
+130
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you could also use a ternary here and would look like let score = word.length >= 6 ? 8 : 0; |
||
} | ||
return score; | ||
}; | ||
|
||
export const getIndexTieBreak = (highestScoringWords) => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍🏽 |
||
// Break ties from highestScoreFrom | ||
let highestIndex = 0; | ||
for (let i = 0; i < highestScoringWords.length; i++) { | ||
if (highestScoringWords[i].length === 10) { | ||
return i; | ||
} else if ( | ||
highestScoringWords[i].length < highestScoringWords[highestIndex].length | ||
) { | ||
highestIndex = i; | ||
} | ||
} | ||
return highestIndex; | ||
}; | ||
|
||
export const highestScoreFrom = (words) => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍🏽 |
||
// Implement this method for wave 1 | ||
let highestScoringWords = []; | ||
let highScore = 0; | ||
let highScoreIndex = 0; | ||
for (let word of words) { | ||
let score = scoreWord(word); | ||
if (score > highScore) { | ||
highestScoringWords = [word]; | ||
highScore = score; | ||
} else if (score === highScore) { | ||
highestScoringWords.push(word); | ||
} | ||
} | ||
if (highestScoringWords.length > 1) { | ||
highScoreIndex = getIndexTieBreak(highestScoringWords); | ||
} | ||
return { word: highestScoringWords[highScoreIndex], score: highScore }; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a good approach! During our review, we also saw someone use a spread operator. A few different ways to do it! You can also go ahead and remove the commented code to clean it up.