Add support for custom I2C SDA and SCL pins #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the scope of your change--i.e. what the change does and what parts of the code were modified.
Added feature to let users specify custom SDA and SCL pins.
No breaking changes were made. Existing code which does not specify any pins will run unchanged.
Describe any known limitations with your change.
none known
Please run any tests or examples that can exercise your modified code.
Tested and Working on ESP32 (Wemos D1 Mini HW655 using multiple arrangements of pins 5, 16, 17, 18, 21, 22)
NOTE1 - existing code was attempting to cast as (byte) arguments that were expected to be (int) within esp32 Wire lib
NOTE2 - existing code was attempting to pass "True" bool into (int) datatype within esp32 Wire lib
The above 2 issues were fixed to build this successfully on esp32