Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package Files Bundled Outside Package Folder #45

Open
sommersoft opened this issue Aug 13, 2019 · 2 comments
Open

Package Files Bundled Outside Package Folder #45

sommersoft opened this issue Aug 13, 2019 · 2 comments

Comments

@sommersoft
Copy link
Collaborator

Discovered in #1234.

When files are in a package folder, but the package_folder_prefix doesn't match the package foldername, the files are bundled outside of the package folder.

@2bndy5
Copy link
Contributor

2bndy5 commented Aug 15, 2019

my output in travis CI:

$ circuitpython-build-bundles --filename_prefix circuitpython-nrf24l01 --library_location circuitpython_nrf24l01 --package_folder_prefix circuitpython_

build.library failure: /home/travis/build/2bndy5/CircuitPython_nRF24L01/circuitpython_nrf24l01

Multiple top level py files not allowed. Please put them in a package or combine them into a single file.

am I getting the structure wrong? I have 2 .py files in the "circuitpython_nrf24l01" (not includiing the init.py) folder located in repo's root.

@2bndy5
Copy link
Contributor

2bndy5 commented Aug 17, 2019

using circuitpython-build-bundles --library_location . --package_folder_prefix circuitpython_ --filename_prefix circuitpython_nrf24l01 seemed to have fixed it. travis CI output:

Zipping
circuitpython_nrf24l01-4.x-mpy-d9ff736/examples/fakeBLE/m4_test.py 1137 1536
circuitpython_nrf24l01-4.x-mpy-d9ff736/examples/interrupt/m4_test.py 4373 4608
circuitpython_nrf24l01-4.x-mpy-d9ff736/examples/interrupt/pi_test.py 4413 4608
circuitpython_nrf24l01-4.x-mpy-d9ff736/examples/ack_payloads/m4_test.py 4743 5120
circuitpython_nrf24l01-4.x-mpy-d9ff736/examples/ack_payloads/pi_test.py 4747 5120
circuitpython_nrf24l01-4.x-mpy-d9ff736/examples/context/m4_test.py 2866 3072
circuitpython_nrf24l01-4.x-mpy-d9ff736/examples/context/pi_test.py 2818 3072
circuitpython_nrf24l01-4.x-mpy-d9ff736/examples/stream/m4_test.py 2901 3072
circuitpython_nrf24l01-4.x-mpy-d9ff736/examples/stream/pi_test.py 2908 3072
circuitpython_nrf24l01-4.x-mpy-d9ff736/examples/simple/m4_test.py 3443 3584
circuitpython_nrf24l01-4.x-mpy-d9ff736/examples/simple/pi_test.py 3487 3584
circuitpython_nrf24l01-4.x-mpy-d9ff736/lib/circuitpython_nrf24l01/rf24.mpy 19630 19968
circuitpython_nrf24l01-4.x-mpy-d9ff736/lib/circuitpython_nrf24l01/fake_ble.mpy 2968 3072
circuitpython_nrf24l01-4.x-mpy-d9ff736/lib/circuitpython_nrf24l01/__init__.py 0 0

@sommersoft thanx for the advice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants