addresses #103 #105
addresses #103 #105
Conversation
| if sys.version_info < (3, 8): | ||
| import importlib_metadata | ||
| else: | ||
| import importlib.metadata as importlib_metadata | ||
|
|
There was a problem hiding this comment.
yikes. maybe we should start by seeing if we can move relevant github actions workflows to newer python. For instance, the circuitpython bundle uses 3.10 presently: https://github.com/adafruit/Adafruit_CircuitPython_Bundle/blob/main/.github/workflows/build.yml#L24 and newly cookie-cut libs use 3.11 https://github.com/adafruit/workflows-circuitpython-libs/blob/main/build/action.yml#L11
There was a problem hiding this comment.
Since python v3.7 is deprecated, we could bump the minimum python version to 3.8 and the changes to requirements.txt and corresponding import here would get simplified.
Not sure what the motivation is behind bumping the minimum supported python version. Is it meant to keep the quantity of non-std deps low? Were you hoping for less complex imports?
There was a problem hiding this comment.
yeah specifically I was reacting to needing to add this version dependent code. I don't know why the workflows here are at 3.7 while we have 3.10 and 3.11 where it's actually being used.
There was a problem hiding this comment.
Even if you upgrade the version used in workflows, the pkg supported version is still set to
circuitpython-build-tools/setup.py
Line 16 in b49cd84
Again, python 3.7 has reached end-of-life in 2023-06-27 (see PEP537).
|
If at any point this starts to feel like too much of a moving target, feel free to say so and we can get some element of it merged because that's better than fixing anything (and part of why I split off the README into a separate issue) |
I hadn't considered the administrative side of this (upgrading minimum supported python, etc). My main focus was to just fix support for python v3.12 (& ensure backward compatible behavior). As you pointed out, the newer CI (composite) workflows are pinned to using a python v3.11, so there's probably no rush on this from the average end-user perspective. |
| if sys.version_info < (3, 8): | ||
| import importlib_metadata | ||
| else: | ||
| import importlib.metadata as importlib_metadata | ||
|
|
There was a problem hiding this comment.
yeah specifically I was reacting to needing to add this version dependent code. I don't know why the workflows here are at 3.7 while we have 3.10 and 3.11 where it's actually being used.
|
thank you |
This is not formatted. I couldn't see anything about contributing guidelines other than code of conduct. Is black used for this project? It doesn't seem like it.
I did run this locally (on Windows with python v3.11.5) and everything seemed to work as expected. However, the newer
importlib_metadata.version()returned a dev spec that wasn't PEP440 compatible; I'm not sure that really matters since I think only stable version specs are used for uploads to pypi.tested with a single module package (circuitpython-cirque-pinnacle) and a multi-module package (circuitpython-nrf24l01)
other chores