-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unexpectedly huge paddings when wrapping a checkbox inside a blank widget #294
Comments
The checkbox class has a max height, the widget class does not. so the wrapped one ends up flexing to 25% of the available window. |
while that's logical I think it might be a bit unreasonable to require people to clone widgets exactly with all their properties properly. Would it be possible to make the paddings and other styles changable? My use-case was that I just wanted to give the checkbox a little bit of padding |
it isn't padding, it is maxHeight. change that in your wrapper and you'll see the behavior magically change class YourWidget { that kind of thing (I think. haven't tried) |
sorry I think you misunderstood, I wanted to say: I'm making this wrapper class because I want to add padding. I don't want to reimplement all the specifics of my padded widget (checkbox -> maxHeight, etc.) Would it be reasonable to allow users to change margin/padding/etc on layouts if not on widgets? |
oh yeah i do want to change the spacing from the parent too, i was thinking about adding that pretty soon as a kind of like grid spacing or something |
using wrapped checkbox:
using checkbox:
code:
it seems it somehow resizes to fill all space now
The text was updated successfully, but these errors were encountered: