-
Notifications
You must be signed in to change notification settings - Fork 557
Count-Min Sketch Constant for Calculating Width #93
Comments
it looks like it was written that way from the first version submitted by @jkff. To clarify for the lazy, the difference is between |
Changing the |
An intern reported this issue to me last month. Being confused, I quickly re-read the papers and noticed that According to git log, @jkff wrote the implementation after this second publication. It could explain why. (I don't have time to do the maths but it would be interesting to investigate this change) |
The paper referenced in the javadoc uses |
I think using the same arguments to the constructors would result in different width and depth parameters which wouldn't be ideal, but the epsilon would adjust itself on deserialization at least. In any case I think the safer bet is just leaving it be. It is curious that there are two versions of this paper without an errata in the later one discussing the changes but at least this mystery is solved. Thanks for the quick responses! |
The width of the sketch according to the paper should be set to
ceil(e/epsilon)
where e is Euler's number. However, I noticed in the current code that this is just set to2.0
.I'm curious as to why this is. Is it good enough in practice for it to not make a difference?
The text was updated successfully, but these errors were encountered: