Add sorting to my alerts #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into kw-add-sorting-to-my-alerts
…into kw-add-sorting-to-my-alerts
dcmcand
suggested changes
Mar 11, 2021
jasalisbury
reviewed
Mar 12, 2021
| }; | ||
|
|
||
| MyAlerts.defaultProps = { | ||
| reports: [], | ||
| alertsSortConfig: { sortBy: 'startDate', direction: 'asc' }, | ||
| alertsOffset: 0, | ||
| alertsPerPage: 7, |
There was a problem hiding this comment.
I changed it to 10, but right now since the pagination is not working it will be a placeholder only until we find a way to integrate the pagination with sorting (HHS#369)
I adjusted the width - it shouldn't jump now. |
jasalisbury
approved these changes
Mar 12, 2021
rahearn
suggested changes
Mar 12, 2021
| to={`/activity-reports/${id}`} | ||
| href={`/activity-reports/${id}`} | ||
| to={idLink} | ||
| href={idLink} |
There was a problem hiding this comment.
Removed href.
| } else { | ||
| to = offsetTo; | ||
| } | ||
| return `${from}-${to} of ${reportsCount}`; |
There was a problem hiding this comment.
Let's hide this until pagination is active. With 11 reports the table is displaying all 11 (good, since otherwise one would be inaccessible) but this says 1-10 of 11 which is confusing
| sequelize, | ||
| } from '../models'; | ||
|
|
||
| const orderReportsBy = (sortBy, sortDir) => { |
There was a problem hiding this comment.
Nice, I like pulling this out into its own function.
rahearn
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Adds sorting to "My Alerts"
How to test
Issue(s)
Checklist