Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web unsupported #23

Open
creativecreatorormaybenot opened this issue Aug 26, 2020 · 3 comments
Open

Web unsupported #23

creativecreatorormaybenot opened this issue Aug 26, 2020 · 3 comments

Comments

@creativecreatorormaybenot
Copy link

creativecreatorormaybenot commented Aug 26, 2020

adjust_sdk does not seem to support Flutter web at this moment.

It would be very benificial if support for that would be added, especially because https://github.com/adjust/web_sdk already exists 👌🏽
Adding it seems like it would be trivial.

For now, we will have to manually call the JavaScript SDK in Flutter web. This has to be done alongside calling the Flutter SDK on mobile, which means that we need an extra layer of abstraction for conditional imports.

@uerceg
Copy link
Contributor

uerceg commented Feb 22, 2021

HI @creativecreatorormaybenot

And sorry for quite delayed reply in here. This is (for now) something we don't really have in our roadmap so at this moment, we don't actively plan to work on this. However, in case you have some functional version of this, you're more than welcomed to open PR with those changes and explanation on how this can be run / tested and we would try to take a look at that.

Since we never really touched into this topic, question about it: Would both, mobile and web versions of SDK have unified Dart API (pretty much Dart classes we currently have with mobile SDK version)? Because web and mobile SDKs, even though they have similarities, they in practice don't really have all things in common. Mobile SDK API is richer and some features which exist in mobile SDKs don't exist in web SDK and vice versa.

@creativecreatorormaybenot
Copy link
Author

@uerceg Thanks for your response. The idea would be sharing an API, usually via an adjust_sdk_platform_interface. I think it would not be a problem, however.

You would simply explain in the docs when a function is web/mobile-only and then throw an UnimplementedError on the particular platform :)

@WillNeill
Copy link

Hi @uerceg, just picking up on this thread now it's a few years later and Flutter Web is stable with growing support.

Is there any update about whether this is something on the roadmap?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants