Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres modules don't check libpq errors #80

Open
65278 opened this issue Feb 5, 2020 · 0 comments · May be fixed by #114
Open

Postgres modules don't check libpq errors #80

65278 opened this issue Feb 5, 2020 · 0 comments · May be fixed by #114

Comments

@65278
Copy link
Contributor

65278 commented Feb 5, 2020

In postgres.c,exports.c and utils/postgres.c:
The only command that is checked for errors is PQexec(m->conn_master, m->cpycmd);
Which is the only place where we can notice that something about the postgres connection fails.
This leads to the loss of data in many constellations.

Furthermore, as we batch 2000 lines for copy, but have the messages already destroyed in the queue, we need a solution to retain the messages in case of copy error (possibly a ring buffer).

@alip alip linked a pull request Dec 8, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant