Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not change Value-Only type for Range: stay with number #407

Open
BirgitBoss opened this issue Apr 12, 2024 · 3 comments
Open

Do not change Value-Only type for Range: stay with number #407

BirgitBoss opened this issue Apr 12, 2024 · 3 comments
Labels
accepted accepted in principle to be fixed specification impact on specification and thus on xml, json etc., label "aas-core" not set additinally
Milestone

Comments

@BirgitBoss
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Up to V3.0 Part 2 the Value-only schema requested

"RangeValue": { "type": "object", "properties": { "min": { "type": "number" }, "max": { "type": "number" } },

Now the request came up why this is limited to numbers and there was a decision to allow all types for Range as well. However, this does not really make sense from my point of view.

The types for a Property are like follows:

"PropertyValue": {
"oneOf": [
{
"$ref": "#/definitions/StringValue"
},
{
"$ref": "#/definitions/NumberValue"
},
{
"$ref": "#/definitions/BooleanValue"
}
]
},

However, a Range of Boolean does not make any sense.
A Range of strings may exist but is the order clearly defined?

@BirgitBoss BirgitBoss added this to the V3.1 milestone Apr 12, 2024
@BirgitBoss BirgitBoss added requires workstream approval strategic decision in spec team needed specification impact on specification and thus on xml, json etc., label "aas-core" not set additinally labels Apr 12, 2024
@mristin
Copy link
Collaborator

mristin commented Apr 12, 2024

I think it also needs to be defined what happens if a non-value-only POST request sends a Range with strings or other types.

Non-value-only GET can retrieve such Ranges. Is value-only endpoint expected to crash? Or what should it do?

(This is a broader issue and applies to everything number in the API. We use strings for non-value-only representation.)

@BirgitBoss
Copy link
Collaborator Author

BirgitBoss commented May 15, 2024

Decision Proposal TF AAS Part 1:

  • no change
    It is true that Boolean Range does not make sense but it is the task of SMT creators to only define elements that are useful

==> Schema Value-Only needs to be adapted

@BirgitBoss BirgitBoss added ready for approval TF proposes how to resolve the issue. Needs final approval my Workstream and removed requires workstream approval strategic decision in spec team needed labels May 29, 2024
@BirgitBoss
Copy link
Collaborator Author

Workstream AAS Spec 2024-06-13
accepted: no change

@BirgitBoss BirgitBoss added accepted accepted in principle to be fixed and removed ready for approval TF proposes how to resolve the issue. Needs final approval my Workstream labels Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted accepted in principle to be fixed specification impact on specification and thus on xml, json etc., label "aas-core" not set additinally
Projects
None yet
Development

No branches or pull requests

2 participants