Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove abstract Class HasKind and incorporate directly in class Submodel #434

Open
BirgitBoss opened this issue May 27, 2024 · 2 comments
Open

Remove abstract Class HasKind and incorporate directly in class Submodel #434

BirgitBoss opened this issue May 27, 2024 · 2 comments
Labels
accepted accepted in principle to be fixed specification impact on specification and thus on xml, json etc., label "aas-core" not set additinally
Milestone
V4.x

Comments

@BirgitBoss
Copy link
Collaborator

BirgitBoss commented May 27, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
The only class inherting HasKind is Submodel (in former versions it was also SubmodelElement). Abstract classes are typically only introduced if several classes are inheriting from them.

Describe the solution you'd like
Remove abstract Class HasKind and incorporate directly in class Submodel

The change is backward compatible but changes the schemas implementing the abstract classes as well.

Some constraints are effected like Constraint AASd-119: If any Qualifier/kind value of a Qualifiable/qualifier is equal to TemplateQualifier and the qualified element inherits from "hasKind" then the qualified element shall be of kind Template (HasKind/kind = "Template").
@BirgitBoss BirgitBoss added this to the V3.1 milestone May 27, 2024
@BirgitBoss BirgitBoss added the specification impact on specification and thus on xml, json etc., label "aas-core" not set additinally label May 27, 2024
@BirgitBoss BirgitBoss changed the title Remove abstract Class hasKind and incorporate directly in class Subclass Remove abstract Class HasKind and incorporate directly in class Subclass May 27, 2024
@BirgitBoss BirgitBoss added the requires workstream approval strategic decision in spec team needed label May 29, 2024
@BirgitBoss BirgitBoss changed the title Remove abstract Class HasKind and incorporate directly in class Subclass Remove abstract Class HasKind and incorporate directly in class Submodel Oct 16, 2024
@BirgitBoss
Copy link
Collaborator Author

2024-10-16 TF AAS Metamodel

  • approval: Remove abstract Class HasKind and incorporate directly in class Submodel
    Because: only inherited by Submodel + IEC 63278 will not introduce abstract Class HasKind
    Backward compatibility for data consumers is given. Tool developers might need to change their class structure
    ==> introduce for 4.0

@BirgitBoss BirgitBoss modified the milestones: V3.1, V4.x Oct 16, 2024
@BirgitBoss BirgitBoss added ready for approval TF proposes how to resolve the issue. Needs final approval my Workstream and removed requires workstream approval strategic decision in spec team needed labels Oct 16, 2024
@BirgitBoss BirgitBoss added the accepted accepted in principle to be fixed label Nov 14, 2024
@BirgitBoss
Copy link
Collaborator Author

2024-11-14 Workstream AAS
Decision Proposal accepted: #434 (comment)

@BirgitBoss BirgitBoss removed the ready for approval TF proposes how to resolve the issue. Needs final approval my Workstream label Nov 14, 2024
@BirgitBoss BirgitBoss mentioned this issue Nov 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted accepted in principle to be fixed specification impact on specification and thus on xml, json etc., label "aas-core" not set additinally
Projects
None yet
Milestone
V4.x
Development

No branches or pull requests
1 participant
@BirgitBoss