Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Do not use keywords in the meta-model #468

Open
mristin opened this issue Sep 12, 2024 · 1 comment
Open

[BUG] Do not use keywords in the meta-model #468

mristin opened this issue Sep 12, 2024 · 1 comment
Labels
bug Something isn't working specification impact on specification and thus on xml, json etc., label "aas-core" not set additinally
Milestone

Comments

@mristin
Copy link
Collaborator

mristin commented Sep 12, 2024

The class Endpoint contains a property called interface. This makes it ugly for the SDKs to call the property interfacE whenever it is a keyword in the respective language.

Please find attached to this comment a Python snippet (from https://github.com/aas-core-works/aas-core-codegen) listing all the keywords in all the popular programming languages.

Another problematic properties are type, range and result.

keywords-snippet.txt

@mristin mristin added the bug Something isn't working label Sep 12, 2024
@mristin mristin added this to the V4.x milestone Sep 12, 2024
@BirgitBoss
Copy link
Collaborator

Thank you making us aware of these keywords! I made a copy: admin-shell-io/aas-specs-api#320 because the Endpoint you mentioned is defined in Part 2 API domain models.
Since changes w.r.t. to attribute names would be non-backward compatible assignment and consideration for V4.x is suitable.

@BirgitBoss BirgitBoss added the specification impact on specification and thus on xml, json etc., label "aas-core" not set additinally label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working specification impact on specification and thus on xml, json etc., label "aas-core" not set additinally
Projects
None yet
Development

No branches or pull requests

2 participants