Change V3.1 #358

BirgitBoss · 2024-02-21T17:04:33Z

This issue closes
#299
shall be anyUri instead of string + length restriction and note

add anyUri to basic data types section
change PathType definition
update ChangeLog

closes #361

PathType shall be anyUri instead of string

mhrimaz · 2024-02-22T09:35:16Z

@BirgitBoss
Sorry that I jump in, but would that be possible to also change the datatype of other values that are now 'xs:string' to their actual XSD data type?
I have elaborated the issue here: #284
The problem right now is that if we have a Property with a xs:double valueType, in RDF we use string.

So currently we have:

<something_48c66017> rdf:type aas:Submodel ;
    <https://admin-shell.io/aas/3/0/Identifiable/id> "something_48c66017"^^xs:string ;
    <https://admin-shell.io/aas/3/0/Submodel/submodelElements> [
        rdf:type aas:Property ;
        <https://admin-shell.io/aas/3/0/Referable/idShort> "something3fdd3eb4"^^xs:string ;
        <https://admin-shell.io/aas/3/0/Property/valueType> <https://admin-shell.io/aas/3/0/DataTypeDefXsd/Double> ;
###
        <https://admin-shell.io/aas/3/0/Property/value> "1234.01234"^^xs:string ;
    ] ;
.

but it should be:

<something_48c66017> rdf:type aas:Submodel ;
    <https://admin-shell.io/aas/3/0/Identifiable/id> "something_48c66017"^^xs:string ;
    <https://admin-shell.io/aas/3/0/Submodel/submodelElements> [
        rdf:type aas:Property ;
        <https://admin-shell.io/aas/3/0/Referable/idShort> "something3fdd3eb4"^^xs:string ;
        <https://admin-shell.io/aas/3/0/Property/valueType> <https://admin-shell.io/aas/3/0/DataTypeDefXsd/Double> ;
###
        <https://admin-shell.io/aas/3/0/Property/value> "1234.01234"^^xs:double;
    ] ;
.

It might be a breaking change, but it doesn't cause any issues for roundtrips, since the metamodel anyways use XSD datatypes. This would allow to write SPARQL query easier (numeric aggeragation, comparison, ...)

BirgitBoss · 2024-02-22T14:59:41Z

@BirgitBoss Sorry that I jump in, but would that be possible to also change the datatype of other values that are now 'xs:string' to their actual XSD data type? I have elaborated the issue here: #284

Thank you for pointing to this issue. They are both about data types but your problem is more tricky because the type of the property is not always the same but depends on its semantic definition and implementation. For the SME "File" the type is static. So I prefer to discuss the typing issue of Properties (and similar SME) in #284 and to discuss only data type "PathType" in this issue.

Thank you for your understanding.

alexgordtop

I think we should stick with RFC3986, which defines URIs, that are required to resolve resources. This also addresses the issue of fishing attacks with character symbols, that look like the original ones, but lead to a different address. URIs don't have this issue, while IRIs do.

documentation/IDTA-01001/modules/ROOT/pages/Spec/IDTA-01001_Metamodel_DataTypes.adoc

+ added links to xsd schema

BirgitBoss · 2024-02-27T11:38:23Z

@alexgordtop can you now approve of the PR after the changes made?

g1zzm0 · 2024-02-27T14:00:38Z

PathType should not change its type!

Rather, it should migrate the constraints from RFC8089 to RFC3987. This could be achieved by changing from matchesRFC8089 to matchesXsAnyUri. This is necessary to avoid having to create an entire new RegEx from @s-heppner or @mristin because of time constraints. The task force wanted the change from RFC8089 to RFC3987, but nobody wanted to make the change.

According to version 3.0, PathType is an Identifier that is also subject to the matchesRFC8089 constraint. The PathType cannot simply be changed to anyUri because anyUri is not a primitive type. This is breaking to version 3.0 and cannot be implemented in aas-core.
No approval from me.

documentation/IDTA-01001/modules/ROOT/pages/IDTA-01001_ChangeLog.adoc

documentation/IDTA-01001/modules/ROOT/pages/Spec/IDTA-01001_Metamodel_DataTypes.adoc

…og.adoc Co-authored-by: Nico Braunisch <[email protected]>

…tamodel_DataTypes.adoc Co-authored-by: Nico Braunisch <[email protected]>

BirgitBoss · 2024-02-29T16:58:45Z

see revised decision in #299

g1zzm0 · 2024-02-29T17:02:13Z

documentation/IDTA-01001/modules/ROOT/pages/Spec/IDTA-01001_Metamodel_DataTypes.adoc

-Note: URL, based on [RFC-3986](https://www.rfc-editor.org/rfc/rfc3987) /[RFC-3987](https://www.rfc-editor.org/rfc/rfc3987), but more recently defined as living standard by WHATWG, as suggested by W3C: https://url.spec.whatwg.org/
+"[anyURI supports a] wide range of internationalized resource identifiers can be specified when an anyURI is called for, and still be understood as URIs per https://www.w3.org/TR/xmlschema11-2/#RFC3986[RFC 3986] and its successor(s)." 
+
+Source: https://www.w3.org/TR/xmlschema11-2/#anyURI[W3C XML Schema Definition Language (XSD) 1.1 Part 2: Datatypes]


Suggested change

Source: https://www.w3.org/TR/xmlschema11-2/#anyURI[W3C XML Schema Definition Language (XSD) 1.1 Part 2: Datatypes]

Source: https://www.w3.org/TR/xmlschema-2/#anyURI[W3C XML Schema Definition Language (XSD) 1.0 Part 2: Datatypes]

g1zzm0 · 2024-02-29T17:04:37Z

documentation/IDTA-01001/modules/ROOT/pages/Spec/IDTA-01001_Metamodel_DataTypes.adoc



 ====
-Note: URL, based on [RFC-3986](https://www.rfc-editor.org/rfc/rfc3987) /[RFC-3987](https://www.rfc-editor.org/rfc/rfc3987), but more recently defined as living standard by WHATWG, as suggested by W3C: https://url.spec.whatwg.org/
+"[anyURI supports a] wide range of internationalized resource identifiers can be specified when an anyURI is called for, and still be understood as URIs per https://www.w3.org/TR/xmlschema11-2/#RFC3986[RFC 3986] and its successor(s)." 


Suggested change

"[anyURI supports a] wide range of internationalized resource identifiers can be specified when an anyURI is called for, and still be understood as URIs per https://www.w3.org/TR/xmlschema11-2/#RFC3986[RFC 3986] and its successor(s)."

"[anyURI supports a] wide range of internationalized resource identifiers can be specified when an anyURI is called for, and still be understood as URIs per https://www.w3.org/TR/xmlschema-2/#RFC2396[RFC 2396] and https://www.w3.org/TR/xmlschema-2/#RFC2732[RFC 2732] ."

g1zzm0 · 2024-02-29T17:05:37Z

documentation/IDTA-01001/modules/ROOT/pages/Spec/IDTA-01001_Metamodel_DataTypes.adoc

 "2000-01-01T14:23:00.66372+14:00"footnote:[Corresponds to xs:dateTimeStamp in XML Schema 1.1]
-|xsd |duration |Duration of time |"-P1Y2M3DT1H", +
+
+|xsd |https://www.w3.org/TR/xmlschema2/#duration[duration] |Duration of time |"-P1Y2M3DT1H", +


g1zzm0 · 2024-02-29T17:10:49Z

documentation/IDTA-01001/modules/ROOT/pages/Spec/IDTA-01001_Metamodel_DataTypes.adoc

+
+FTP://unicode.org
+
+|xsd |https://www.w3.org/TR/xmlschema2/#dateType[dateType] |Date and time with or without time zone |"2000-01-01T14:23:00", +


Suggested change

|xsd |https://www.w3.org/TR/xmlschema2/#dateType[dateType] |Date and time with or without time zone |"2000-01-01T14:23:00", +

|xsd |https://www.w3.org/TR/xmlschema-2/#dateTime[dateTime] |Date and time with or without time zone |"2000-01-01T14:23:00", +

g1zzm0 · 2024-02-29T17:12:09Z

documentation/IDTA-01001/modules/ROOT/pages/Spec/IDTA-01001_Metamodel_DataTypes.adoc

+
+|xsd |https://www.w3.org/TR/xmlschema2/#base64Binary[base64Binary] |base64-encoded binary data |"a3Vtb3dhc2hlcmU="
+
+|xsd |https://www.w3.org/TR/xmlschema2/#boolean[boolean] |true, false |true, false


g1zzm0 · 2024-02-29T17:12:25Z

documentation/IDTA-01001/modules/ROOT/pages/Spec/IDTA-01001_Metamodel_DataTypes.adoc

-|xsd |boolean |true, false |true, false
-|xsd |dateType |Date and time with or without time zone |"2000-01-01T14:23:00", +
+
+|xsd |https://www.w3.org/TR/xmlschema2/#base64Binary[base64Binary] |base64-encoded binary data |"a3Vtb3dhc2hlcmU="


g1zzm0 · 2024-02-29T17:12:59Z

documentation/IDTA-01001/modules/ROOT/pages/Spec/IDTA-01001_Metamodel_DataTypes.adoc


 See Clause 5.3.12.6 for constraints on types.

 .Simple Data Types Used in Metamodel
 [cols="10%,19%,38%,33%",options="header",]
 |===
 |Source |Basic Data Type |Value Range |Sample Values
-|xsd |string |Character string (but not all Unicode character strings) |"Hello world", "Καλημέρα κόσμε", +
+
+|xsd |https://www.w3.org/TR/xmlschema2/#string[string] |Character string (but not all Unicode character strings) |"Hello world", "Καλημέρα κόσμε", +


g1zzm0 · 2024-02-29T17:19:48Z

Allways a good idea to mege unaproved PRs.
Please check twice if all XSD Spec Version 1.0 URLs point to https://www.w3.org/TR/xmlschema-2/ and not to https://www.w3.org/TR/xmlschema2/ and for the wrong URLs that point to the wrong XSD Version 1.1 with path https://www.w3.org/TR/xmlschema11-2/

(Edit by @s-heppner): Fix typo in comment

closes #299

4f88c6b

PathType shall be anyUri instead of string

BirgitBoss requested review from AlexanderWollbrink, alexgordtop and g1zzm0 and removed request for AlexanderWollbrink February 21, 2024 17:04

Update ChangeLog to reflect changes on PathType

f4679de

add anyUri to the used basic data types used in the metamodel

baf7a3b

BirgitBoss changed the title ~~closes #299 PathType~~ Closes #299 PathType Feb 22, 2024

bugfix asciidoc: do display "." at the beginning add {blank}

6881017

alexgordtop suggested changes Feb 23, 2024

View reviewed changes

documentation/IDTA-01001/modules/ROOT/pages/Spec/IDTA-01001_Metamodel_DataTypes.adoc Outdated Show resolved Hide resolved

fix anyUri to anyURI

e54fd9e

BirgitBoss changed the title ~~Closes #299 PathType~~ Changes V3.1 Feb 27, 2024

BirgitBoss added 2 commits February 27, 2024 12:23

closes #361 relationshipElement mention semanticId

a26149e

resolve #358 (comment)

d597813

+ added links to xsd schema

alexgordtop approved these changes Feb 27, 2024

View reviewed changes

g1zzm0 changed the title ~~Changes V3.1~~ Change V3.1 Feb 27, 2024

g1zzm0 reviewed Feb 28, 2024

View reviewed changes

documentation/IDTA-01001/modules/ROOT/pages/IDTA-01001_ChangeLog.adoc Outdated Show resolved Hide resolved

g1zzm0 reviewed Feb 28, 2024

View reviewed changes

documentation/IDTA-01001/modules/ROOT/pages/IDTA-01001_ChangeLog.adoc Outdated Show resolved Hide resolved

g1zzm0 reviewed Feb 28, 2024

View reviewed changes

documentation/IDTA-01001/modules/ROOT/pages/Spec/IDTA-01001_Metamodel_DataTypes.adoc Outdated Show resolved Hide resolved

g1zzm0 requested a review from alexgordtop February 28, 2024 16:32

BirgitBoss and others added 3 commits February 29, 2024 17:55

Update documentation/IDTA-01001/modules/ROOT/pages/IDTA-01001_ChangeL…

cf4317d

…og.adoc Co-authored-by: Nico Braunisch <[email protected]>

Update documentation/IDTA-01001/modules/ROOT/pages/IDTA-01001_ChangeL…

06251a2

…og.adoc Co-authored-by: Nico Braunisch <[email protected]>

Update documentation/IDTA-01001/modules/ROOT/pages/Spec/IDTA-01001_Me…

43fe181

…tamodel_DataTypes.adoc Co-authored-by: Nico Braunisch <[email protected]>

BirgitBoss merged commit ab4cd12 into IDTA-01001-3-1_working Feb 29, 2024
2 checks passed

g1zzm0 reviewed Feb 29, 2024

View reviewed changes

g1zzm0 mentioned this pull request Feb 29, 2024

Fix URLs that should point to xmlschema-2 #368

Merged

BirgitBoss deleted the BiBo/issue-299_PathType branch April 18, 2024 09:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change V3.1 #358

Change V3.1 #358

BirgitBoss commented Feb 21, 2024 •

edited by g1zzm0

Loading

mhrimaz commented Feb 22, 2024

BirgitBoss commented Feb 22, 2024

alexgordtop left a comment

BirgitBoss commented Feb 27, 2024

g1zzm0 commented Feb 27, 2024

BirgitBoss commented Feb 29, 2024

g1zzm0 Feb 29, 2024

g1zzm0 Feb 29, 2024

g1zzm0 Feb 29, 2024

g1zzm0 Feb 29, 2024

g1zzm0 Feb 29, 2024

g1zzm0 Feb 29, 2024

g1zzm0 Feb 29, 2024

g1zzm0 commented Feb 29, 2024 •

edited by s-heppner

Loading

	Source: https://www.w3.org/TR/xmlschema11-2/#anyURI[W3C XML Schema Definition Language (XSD) 1.1 Part 2: Datatypes]
	Source: https://www.w3.org/TR/xmlschema-2/#anyURI[W3C XML Schema Definition Language (XSD) 1.0 Part 2: Datatypes]

	"[anyURI supports a] wide range of internationalized resource identifiers can be specified when an anyURI is called for, and still be understood as URIs per https://www.w3.org/TR/xmlschema11-2/#RFC3986[RFC 3986] and its successor(s)."
	"[anyURI supports a] wide range of internationalized resource identifiers can be specified when an anyURI is called for, and still be understood as URIs per https://www.w3.org/TR/xmlschema-2/#RFC2396[RFC 2396] and https://www.w3.org/TR/xmlschema-2/#RFC2732[RFC 2732] ."

	\|xsd \|https://www.w3.org/TR/xmlschema2/#duration[duration] \|Duration of time \|"-P1Y2M3DT1H", +
	\|xsd \|https://www.w3.org/TR/xmlschema-2/#duration[duration] \|Duration of time \|"-P1Y2M3DT1H", +


		FTP://unicode.org

		\|xsd \|https://www.w3.org/TR/xmlschema2/#dateType[dateType] \|Date and time with or without time zone \|"2000-01-01T14:23:00", +

Change V3.1 #358

Change V3.1 #358

Conversation

BirgitBoss commented Feb 21, 2024 • edited by g1zzm0 Loading

mhrimaz commented Feb 22, 2024

BirgitBoss commented Feb 22, 2024

alexgordtop left a comment

Choose a reason for hiding this comment

BirgitBoss commented Feb 27, 2024

g1zzm0 commented Feb 27, 2024

BirgitBoss commented Feb 29, 2024

g1zzm0 Feb 29, 2024

Choose a reason for hiding this comment

g1zzm0 Feb 29, 2024

Choose a reason for hiding this comment

g1zzm0 Feb 29, 2024

Choose a reason for hiding this comment

g1zzm0 Feb 29, 2024

Choose a reason for hiding this comment

g1zzm0 Feb 29, 2024

Choose a reason for hiding this comment

g1zzm0 Feb 29, 2024

Choose a reason for hiding this comment

g1zzm0 Feb 29, 2024

Choose a reason for hiding this comment

g1zzm0 commented Feb 29, 2024 • edited by s-heppner Loading

BirgitBoss commented Feb 21, 2024 •

edited by g1zzm0

Loading

g1zzm0 commented Feb 29, 2024 •

edited by s-heppner

Loading