Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion of CRDs #4

Open
evolvedlight opened this issue Jan 13, 2020 · 3 comments
Open

Completion of CRDs #4

evolvedlight opened this issue Jan 13, 2020 · 3 comments

Comments

@evolvedlight
Copy link

Hi,

I tried this out and it works nicely for the basics, however it's not very complete and so doesn't work, for example for adding new environment variables into a deployment config.

I guess these were handcoded for just your needs? Any idea if it'd be possible to generate full CRDs, or I should just try to extend by hand?

Thanks,
Steve

@BorntraegerMarc
Copy link

@evolvedlight you ever managed to use this?

@evolvedlight
Copy link
Author

Hi @BorntraegerMarc ,
No, we're probably going to go in a different direction and not use this. We're not sure what to use instead yet though.

@Intey
Copy link

Intey commented Dec 25, 2020

Hello, Thanks for this crds! With that, I found hope that it's really can be kustomizable withoud duplications, and with easy changes.

But we get same issues.

For example, we declare in kustomize base DeploymentConfig with predefined env vars: kafka broker secret, and so on.
in overlays, if it's all works correctly, i need to recrete secret and reuse env definitions from base layers.
So, it's like "API" of parent resource (like in OOP with objects and virtual methods or interfaces).

I try to use this with DeploymentConfig, and in overlay i add some new secrets (as mount volumes), change replicas count and in builded result get DeploymentConfig with volumes, changed replicas, but withoud predefined envs.

As workaround, we can use simple json-patches, or redeclare all needed stuff in overlay, but in last case we didn't use base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants