Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unfriendly error when re-deploying #560

Open
purplecabbage opened this issue Jul 18, 2022 · 2 comments
Open

unfriendly error when re-deploying #560

purplecabbage opened this issue Jul 18, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@purplecabbage
Copy link
Member

Describe the bug

The error message is not clear

To Reproduce
run aio app deploy on a production workspace that has already been deployed+approved

Expected behavior
A clear error message stating the error condition, and how to fix it is shown

Instead it looks like the entire error object is output, which is not very friendly

test-stage-july22 AIO_CLI_ENV=stage aio app deploy
✔ Built 1 action(s) for 'dx/excshell/1'
✔ Building web assets for 'dx/excshell/1'
✔ Deployed 1 action(s) for 'dx/excshell/1'
✔ Deploying web assets for 'dx/excshell/1'
Your deployed actions:
web actions:
  -> https://development-918-jessestagetest.dev.runtime.adobe.io/api/v1/web/dx-excshell-1/generic 
To view your deployed application:
  -> https://development-918-jessestagetest.dev.runtime.adobe.io/index.html
To view your deployed application in the Experience Cloud shell:
  -> https://experience-stage.adobe.com/?devMode=true#/custom-apps/?localDevUrl=https://development-918-jessestagetest.dev.runtime.adobe.io/index.html
⠴ Updating Extension Points 'endpoints' in Workspace=Production... ›   Error: [CoreConsoleAPISDK:ERROR_UPDATE_WORKSPACE_ENDPOINTS] 400 - Bad Request 
 ›   ([{"template":"ERR_MSG_RETRY_OR_CONTACT","message":"{\"errors\":[{\"error_code\":\"1400\",\"message\":\"Problem occured - App in 
 ›   DRAFT|REJECTED|RETRACTED status can only be updated\"}]}"}])
⠦ Updating Extension Points 'endpoints' in Workspace=Production...%            
@purplecabbage purplecabbage added the bug Something isn't working label Jul 18, 2022
@aiojbot
Copy link
Collaborator

aiojbot commented Aug 11, 2022

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-1740

@shazron
Copy link
Member

shazron commented Feb 22, 2023

This seems to be a general error object formatting issue in aio-lib-core-errors but I suspect we need to tweak aio-lib-console to pretty print errors https://github.com/adobe/aio-lib-console/blob/65087ad0c3f856d1c4ca0011fdec8c2ccb1ff217/src/index.js#L1260 (and similar libs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants