-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ACNA-1375 - updater for runtimes.json for aio app run --local #557
Conversation
Codecov Report
@@ Coverage Diff @@
## master #557 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 50 50
Lines 2598 2598
Branches 473 473
=========================================
Hits 2598 2598 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but could you give me more insights on when get runtimes is called
I added a npm script that one of the team can run to update the json. This is a manual process, I'm not sure if it should be run automatic for the user (and cached) for local development, although it might be a good idea |
Ok do this automatically would be better, but maybe as a future step, we could open an issue ? |
yeah let's do that for the future |
@moritzraho filed the issue for the automatic update #558 |
Description
Closes #491
Types of changes
Checklist: