-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call in-process hook for deploy-action with parameters #610
Conversation
… it the actions being deployed
Codecov Report
@@ Coverage Diff @@
## master #610 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 54 54
Lines 2822 2828 +6
Branches 528 531 +3
=========================================
+ Hits 2822 2828 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like this a lot... Seems like the nextgen for app builder internal plugin hooks. Very extensible
Tested using:
|
Description
feat: Adds call to oclif hooks for
deploy-action
during run/deploy and pass… it the actions being deployedPrevious hook implementation was not fine-grained enough as when the package-script for
deploy-action
was called, there was no context of what action was being deployed and the hook-script developer had to parse the cli params themselves to see -a action-1 filters.This hopefully allows aio-cli plugin developers a more focused hook where they implement only the required amount and not respond to every oclif hook event
init, prerun, postrun
InProc hook is fired during the deploy-action stage of:
aio app deploy
aio app deploy -a actionname
aio app run
aio app run --local
Related Issue
Working on this revealed #608
Motivation and Context
2 paths that should fire an inproc hook ...
aio app deploy [--action some-action]
aio app run [--local]
How Has This Been Tested?
To verify my hook (emiter) was working as expected, I added a quick hook (responder) to the app plugin.
Here is the output of various commands I ran to test, using the sample test hook above.
Screenshots (if appropriate):
Types of changes
Checklist: