Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACNA-1106] Omit old logs while continuous logs fetching #245

Conversation

florind-ens
Copy link
Contributor

@florind-ens florind-ens commented Aug 19, 2021

Description

Related Issue

Fixes #225
adobe/aio-cli-plugin-app#277

Motivation and Context

startTime is being used to filter out the logs to be printed.
While --tail or any other continuously fetching param, it should only fetch logs since Date.now().

How Has This Been Tested?

Steps:

  1. cd into the generated firefly project.
  2. run aio runtime activation logs --tail.
  3. While aio runtime activation logs --tail is running, generate some logs via the firefly app.
    Expected: Only logs following the aio runtime activation logs --tail should be printed.

Steps:

  1. cd firefly project.
  2. run aio runtime activation logs
    Expected: Logs prior to aio runtime activation logs should be printed.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #245 (a7aeff0) into master (50d92b4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #245   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           58        58           
  Lines         1568      1570    +2     
  Branches       311       312    +1     
=========================================
+ Hits          1568      1570    +2     
Impacted Files Coverage Δ
src/commands/runtime/activation/logs.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50d92b4...a7aeff0. Read the comment docs.

@shazron
Copy link
Member

shazron commented Aug 20, 2021

@florind12 please fill in the section How Has This Been Tested?

@Himavanth
Copy link
Contributor

Himavanth commented Aug 30, 2021

Closing this as this has been dealt with in adobe/aio-lib-runtime#67 (comment)

@Himavanth Himavanth closed this Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aio runtime activation logs --tail shows last log before running the command
3 participants