Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable baseUrl on quickstarts #695

Open
obarcelonap opened this issue Nov 26, 2024 · 0 comments · May be fixed by adobe/aio-cli-plugin-app#822
Open

Customizable baseUrl on quickstarts #695

obarcelonap opened this issue Nov 26, 2024 · 0 comments · May be fixed by adobe/aio-cli-plugin-app#822

Comments

@obarcelonap
Copy link

obarcelonap commented Nov 26, 2024

Expected Behaviour

To be able to set the baseUrl when using quickstar flags in aio app init so repositories out of public github can be used.

aio app init --repo org/repo/folder --baseUrl https://mygit.com

Actual Behaviour

--repo option always uses github.com

Reproduce Scenario (including but not limited to)

Steps to Reproduce

Platform and Version

Sample Code that illustrates the problem

Current implementation uses Octokit that defaults to github.com
https://github.com/adobe/aio-cli-plugin-app/blob/master/src/commands/app/init.js#L375-L378

While Octokit allows to customize the baseUrl with a constructor arg
https://github.com/octokit/octokit.js/blob/main/README.md?plain=1#L184-L203

Logs taken while reproducing problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant