From 33c343b00461a066b04d98cf67f33d8f335bd3fd Mon Sep 17 00:00:00 2001 From: Harminder Virk Date: Tue, 3 Sep 2024 11:29:09 +0530 Subject: [PATCH] refactor: reject child process commands on error --- src/assets_dev_server.ts | 1 + src/bundler.ts | 1 + src/dev_server.ts | 1 + src/test_runner.ts | 1 + 4 files changed, 4 insertions(+) diff --git a/src/assets_dev_server.ts b/src/assets_dev_server.ts index 342eaf5..88516c6 100644 --- a/src/assets_dev_server.ts +++ b/src/assets_dev_server.ts @@ -128,6 +128,7 @@ export class AssetsDevServer { */ this.#devServer = run(this.#cwd, { script: this.#options.cmd, + reject: true, /** * We do not inherit the stdio for vite and encore, because in diff --git a/src/bundler.ts b/src/bundler.ts index b42cc4f..fd932ec 100644 --- a/src/bundler.ts +++ b/src/bundler.ts @@ -113,6 +113,7 @@ export class Bundler { this.#logger.info('compiling frontend assets', { suffix: assetsBundler.cmd }) await run(this.#cwd, { stdio: 'inherit', + reject: true, script: assetsBundler.cmd, scriptArgs: assetsBundler.args, }) diff --git a/src/dev_server.ts b/src/dev_server.ts index 39034fa..b34fdf2 100644 --- a/src/dev_server.ts +++ b/src/dev_server.ts @@ -174,6 +174,7 @@ export class DevServer { script: this.#scriptFile, env: { PORT: port, ...this.#options.env }, nodeArgs: this.#options.nodeArgs, + reject: true, scriptArgs: this.#options.scriptArgs, }) diff --git a/src/test_runner.ts b/src/test_runner.ts index 0842597..eb77241 100644 --- a/src/test_runner.ts +++ b/src/test_runner.ts @@ -228,6 +228,7 @@ export class TestRunner { this.#testScript = runNode(this.#cwd, { script: this.#scriptFile, + reject: true, env: { PORT: port, ...this.#options.env }, nodeArgs: this.#options.nodeArgs, scriptArgs,