Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept STF sha in test pipeline #2680

Closed
llxia opened this issue Jun 25, 2021 · 2 comments
Closed

Accept STF sha in test pipeline #2680

llxia opened this issue Jun 25, 2021 · 2 comments
Assignees

Comments

@llxia
Copy link
Contributor

llxia commented Jun 25, 2021

In order to support Reproducible Tests , our test pipeline should accept STF sha from STF repo. The user/upstream should be able to set STF sha. The test pipeline will use STF sha if it is provided. If not, the branch will be used.

In order to avoid parameter explosion, we should reuse STF_OWNER_BRANCH, so it can be
<owner>:<branch>, <owner>:<tag>, or <owner>:<sha>. SImilar to PR #2829 (get.sh change)

In this case, code needs to be updated in ant:
https://github.com/adoptium/aqa-tests/blob/master/system/common.xml#L51

Please make sure to test both in local and Grinder.

@xius666
Copy link
Contributor

xius666 commented Sep 23, 2021

I would like to take this issue thanks

@llxia
Copy link
Contributor Author

llxia commented Mar 2, 2022

This issue is resolved.

@llxia llxia closed this as completed Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants