Trigger PR builds #4795
Trigger PR builds #4795
Conversation
|
Below are the test job links |
KapilPowar
force-pushed
the
jcksync
branch
2 times, most recently
from
291d66e to
9bd601d
Compare
|
Below are the test job links |
buildenv/jenkins/jck_sync
Outdated
| if (EXITCODE == 2) { | ||
| echo "Script returned exit code 2, No new update available. Marking the job as SUCCESS. " | ||
| } else if (EXITCODE == 0) { | ||
| echo "Script returned exit code 0, new update is available and PR is created." | ||
| def matcher = (scriptOutput =~ /PR_NUMBER=\s*(\d+)/) |
There was a problem hiding this comment.
I do not see any scriptOutput when EXITCODE = 2
buildenv/jenkins/jck_sync
Outdated
| if (EXITCODE == 2) { | ||
| echo "Script returned exit code 2, No new update available. Marking the job as SUCCESS. " | ||
| echo "Script returned exit code 2, No new update available. The job is completed without further action. " |
There was a problem hiding this comment.
When EXITCODE = 2, there is nothing to do. We should return. See #4795 (comment)
There was a problem hiding this comment.
if EXITCODE = 2 using error to stop the execution. And marking the currentBuild.result = "SUCCESS"
return is not working here.
|
Below are the test job links |
| CHILD_PARAMS << booleanParam(name: param.key, value: value.toBoolean()) | ||
| } else { | ||
| CHILD_PARAMS << string(name: param.key, value: value) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
- No, SDK_RESOURCE = releases is not correct. I meant if CUSTOMIZED_SDK_URL is pointing to a specific URL, then we cannot pass the parent CUSTOMIZED_SDK_URL to the child jobs as the child jobs can run on multiple platforms. The best way to do it is to add a comment in the Jenkins job config to warn the users. Please remove the settings of SDK_RESOURCE and CUSTOMIZED_SDK_URL.
- Also, to simplify this, I think we should not use LABEL for two separate purposes. We should rename the LABEL to SYNC_LABEL. See line 6 - 10
|
Below are the test job links |
#1182
Signed-off-by: Kapil Powar [email protected]
CC: @llxia