New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move getJtreg ant target to a shared location #4848

Closed

smlambert opened this issue Nov 2, 2023 · 3 comments · Fixed by #4871 or adoptium/TKG#473

Labels

Contributor

smlambert commented Nov 2, 2023

As mentioned in #4835 (comment) and also noting that jtreg is used for both openjdk and functional test groups, we should pull that target into a utilities file so it can be included into the different test groups where its used (and avoid duplicate ant script code).

https://github.com/adoptium/aqa-tests/blob/master/openjdk/build.xml#L86-L117
https://github.com/adoptium/aqa-tests/blob/master/functional/security/Crypto/build.xml#L97-L132
and in the ssl-tests also.

smlambert added the enhancement label

smlambert added this to Adoptium 4Q 2023 Plan

smlambert mentioned this issue

Add ssl-tests #4835

Merged

Contributor

llxia commented Nov 2, 2023

Just for the record, the jtreg jar version logic: https://github.com/adoptium/aqa-tests/blob/master/openjdk/build.xml#L44-L67

Contributor

llxia commented Nov 3, 2023

@annaibm Please take a look at this issue after #4853 is merged. Thanks

Contributor

llxia commented Nov 6, 2023

We may want to put the common code under https://github.com/adoptium/TKG/tree/master/scripts

annaibm added a commit to annaibm/aqa-tests that referenced this issue


          Copy getJtreg to shared location

f2a5808

-Moved the getJtreg version to TKG/scripts/getDependencies.xml

resolves : adoptium#4848

Signed-off-by: Anna Babu Palathingal <[email protected]>

annaibm added a commit to annaibm/TKG that referenced this issue


          Copy getJtreg to shared location

-Moved the getJtreg version to TKG/scripts/getDependencies.xml

resolves : adoptium/aqa-tests#4848

Signed-off-by: Anna Babu Palathingal <[email protected]>

annaibm added a commit to annaibm/aqa-tests that referenced this issue


          Copy getJtreg to shared location

-Added target to get Jtreg version based on JDK version
-Moved the getJtreg tar download logic to TKG/scripts/getDependencies.xml

resolves : adoptium#4848

Signed-off-by: Anna Babu Palathingal <[email protected]>

annaibm added a commit to annaibm/TKG that referenced this issue


           Move getJtreg into getDependencies

01a65c7

-Moved the getJtreg version download logic into TKG/scripts/getDependencies.xml

resolves : adoptium/aqa-tests#4848

Signed-off-by: Anna Babu Palathingal <[email protected]>

annaibm added a commit to annaibm/aqa-tests that referenced this issue


          Copy getJtreg to shared location

d854b43

-Moved the getJtreg version to TKG/scripts/getDependencies.xml

-Moved getJtreg version from `openjdk`, `functional/Security/Crypto`, and `ssl-tests`

resolves : adoptium#4848

Signed-off-by: Anna Babu Palathingal <[email protected]>

annaibm added a commit to annaibm/TKG that referenced this issue


           Move getJtreg into getDependencies

d05fa66

-Moved the getJtreg version download logic into TKG/scripts/getDependencies.xml

resolves : adoptium/aqa-tests#4848

Signed-off-by: Anna Babu Palathingal <[email protected]>

annaibm added a commit to annaibm/TKG that referenced this issue


           Move getJtreg into getDependencies

f0d04dc

-Moved the getJtreg version download logic into TKG/scripts/getDependencies.xml

resolves : adoptium/aqa-tests#4848

Signed-off-by: Anna Babu Palathingal <[email protected]>

annaibm added a commit to annaibm/aqa-tests that referenced this issue


          Copy getJtreg to shared location

-Added target to get Jtreg version based on JDK version
-Moved the getJtreg tar download logic to TKG/scripts/getDependencies.xml

resolves : adoptium#4848

Signed-off-by: Anna Babu Palathingal <[email protected]>

annaibm added a commit to annaibm/TKG that referenced this issue


          Move getJtreg into getDependencies

2cd6688

-Moved the getJtreg version download logic into TKG/scripts/getDependencies.xml

resolves : adoptium/aqa-tests#4848

Signed-off-by: Anna Babu Palathingal <[email protected]>

annaibm added a commit to annaibm/aqa-tests that referenced this issue


          Copy getJtreg to shared location

4dc8b73

-Added target to get Jtreg version based on JDK version
-Moved the getJtreg tar download logic to TKG/scripts/getDependencies.xml

resolves : adoptium#4848

Signed-off-by: Anna Babu Palathingal <[email protected]>

This was referenced Nov 15, 2023

Copy getJtreg to shared location #4871

Merged

Move getJtreg into getDependencies adoptium/TKG#473

Merged

annaibm added a commit to annaibm/TKG that referenced this issue


          Move getJtreg into getDependencies

ea1462c

-Moved the getJtreg version download logic into TKG/scripts/getDependencies.xml

resolves : adoptium/aqa-tests#4848

Signed-off-by: Anna Babu Palathingal <[email protected]>

annaibm added a commit to annaibm/TKG that referenced this issue


          Move getJtreg into getDependencies

a18a625

-Moved the getJtreg version download logic into TKG/scripts/getDependencies.xml

resolves : adoptium/aqa-tests#4848

Signed-off-by: Anna Babu Palathingal <[email protected]>

annaibm added a commit to annaibm/TKG that referenced this issue


          Move getJtreg into getDependencies

b72c45c

-Moved the getJtreg version download logic into TKG/scripts/getDependencies.xml

resolves : adoptium/aqa-tests#4848

Signed-off-by: Anna Babu Palathingal <[email protected]>

annaibm added a commit to annaibm/TKG that referenced this issue


          Move getJtreg into getDependencies

a9772a1

-Moved the getJtreg version download logic into TKG/scripts/getDependencies.xml

resolves : adoptium/aqa-tests#4848

Signed-off-by: Anna Babu Palathingal <[email protected]>

annaibm added a commit to annaibm/TKG that referenced this issue


          Move getJtreg into getDependencies

842f700

-Moved the getJtreg version download logic into TKG/scripts/getDependencies.xml

resolves : adoptium/aqa-tests#4848

Signed-off-by: Anna Babu Palathingal <[email protected]>

annaibm added a commit to annaibm/aqa-tests that referenced this issue


          Copy getJtreg to shared location

d197e2c

-Moved the getJtreg tar download logic to TKG/scripts/getDependencies.xml

resolves : adoptium#4848

Signed-off-by: Anna Babu Palathingal <[email protected]>

annaibm added a commit to annaibm/aqa-tests that referenced this issue


          Copy getJtreg to shared location

0e4e419

-Moved the getJtreg tar download logic to TKG/scripts/getDependencies.xml

resolves : adoptium#4848

Signed-off-by: Anna Babu Palathingal <[email protected]>

annaibm added a commit to annaibm/TKG that referenced this issue


          Move getJtreg into getDependencies

32f84eb

-Moved the getJtreg version download logic into TKG/scripts/getDependencies.xml

resolves : adoptium/aqa-tests#4848

Signed-off-by: Anna Babu Palathingal <[email protected]>

karianna closed this as completed in adoptium/TKG#473

github-project-automation bot moved this to Done in Adoptium 4Q 2023 Plan

smlambert pushed a commit that referenced this issue


          Copy getJtreg to shared location (#4871)

194e8b8

-Moved the getJtreg tar download logic to TKG/scripts/getDependencies.xml

resolves : #4848

Signed-off-by: Anna Babu Palathingal <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment