-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pre-stage test libs on the machine #4902
Conversation
b. during test compilation, only re-download the jar if SHA does not match. Otherwise, do nothing.
|
29cc92e
to
667d7d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor typo in comment, but otherwise LGTM.
buildenv/jenkins/JenkinsfileBase
Outdated
} | ||
// check pre-stage test libs on the machine | ||
// check for each lib. If lib does not exist, donwload it. | ||
// If lib exists, SHA will be check. Redlownload if SHA does not match. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// If lib exists, SHA will be check. Redlownload if SHA does not match. | |
// If lib exists, SHA will be checked. Re-download if SHA does not match. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated. Thanks
Signed-off-by: Lan Xia <[email protected]>
need to merge with adoptium/TKG#476
resolves: #4500