Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude MulticastSendReceiveTests/Promiscuous for all platform #4909

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Exclude MulticastSendReceiveTests/Promiscuous for all platform #4909

merged 1 commit into from
Dec 11, 2023

Conversation

annaibm
Copy link
Contributor

@annaibm annaibm commented Dec 7, 2023

  • Exclude openjdk MulticastSendReceiveTests in jdk_nio for all platforms

related: backlog/issues/783

@llxia
Copy link
Contributor

llxia commented Dec 7, 2023

The title Exclude openjdk tests for all platforms is too general. Please change to a title that is specific to the PR. It will help us to find the PRs in the future.

@annaibm annaibm changed the title Exclude openjdk tests for all platforms Exclude MulticastSendReceiveTests/Promiscuous for all platform Dec 7, 2023
@annaibm
Copy link
Contributor Author

annaibm commented Dec 7, 2023

Grinder test:
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/36714/testReport/

@annaibm annaibm marked this pull request as ready for review December 7, 2023 21:14
JasonFengJ9
JasonFengJ9 approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@JasonFengJ9 JasonFengJ9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JasonFengJ9
Copy link
Contributor

Please exclude these tests for other Java levels as well either in this PR or another PR.

@llxia
Copy link
Contributor

llxia commented Dec 8, 2023

Please feel free to update this PR to include other versions.
After this PR is merged, please cherry-pick it into https://github.com/adoptium/aqa-tests/tree/j9.0.42-release

@annaibm
Exclude MulticastSendReceiveTests for all platform
68c2721 
- Exclude openjdk MulticastSendReceiveTests in jdk_nio for java levels
- Exclude openjdk Promiscuous in jdk_nio for all java levels

Signed-off-by: Anna Babu Palathingal <[email protected]>
@annaibm
Copy link
Contributor Author

annaibm commented Dec 8, 2023

Grinder:
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/36758/testReport/

@karianna
Copy link
Contributor

@annaibm assuming grinder passed then you can merge this.

@llxia llxia merged commit 7059598 into adoptium:master Dec 11, 2023
1 check passed
annaibm added a commit to annaibm/aqa-tests that referenced this pull request Dec 12, 2023
@annaibm
Exclude MulticastSendReceiveTests for all platform (adoptium#4909)
ffec962 
- Exclude openjdk MulticastSendReceiveTests in jdk_nio for java levels
- Exclude openjdk Promiscuous in jdk_nio for all java levels

Signed-off-by: Anna Babu Palathingal <[email protected]>
llxia pushed a commit that referenced this pull request Dec 12, 2023
@annaibm
Exclude MulticastSendReceiveTests for all platform (#4909) (#4916)
8bc815f 
- Exclude openjdk MulticastSendReceiveTests in jdk_nio for java levels
- Exclude openjdk Promiscuous in jdk_nio for all java levels

Signed-off-by: Anna Babu Palathingal <[email protected]>
@annaibm annaibm deleted the exclude_783 branch January 26, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llxia llxia llxia approved these changes

@JasonFengJ9 JasonFengJ9 JasonFengJ9 approved these changes

@karianna karianna karianna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@annaibm @llxia @JasonFengJ9 @karianna