Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use adoptium/ubuntu2004_build_image:linux-riscv64 image for testing on RISC-V #4929

Closed
wants to merge 1 commit into from

Conversation

luhenry
Copy link
Contributor

@luhenry luhenry commented Dec 20, 2023

No description provided.

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be discussed with Alibaba since they are using this functionaly and we need to make sure we don't negatively impact them.

Also will this automatically enable an image with RVV support or will that need extra configuration?

@luhenry
Copy link
Contributor Author

luhenry commented Dec 20, 2023

@sxa is there a variant flag here similarly to the build-side? The current image is not working for testing temurin so it's not working for Rivos.

@sxa
Copy link
Member

sxa commented Dec 21, 2023

From discussion with Ludovic this morning it seems the issue with the current image is that it's using a very old version of qemu. In the short term I'm probably going to look at not using this dynamic functionality on ci.adoptium.net (since it doesn't work and stalls the jobs) in the short term, but then looking to get usable images fired up to test with RVV support.

From #4307 (comment) is seems that the dockerfile for that image is available at https://github.com/dragonwell-project/docker-qemu-riscv64/blob/master/Dockerfile so we may be able to bump the qemu version in there and get a new image (The default parameter in there seems to be for 7.2.0 just now)

is there a variant flag here similarly to the build-side?

It may be possible to do it on the build variant, but I suspect that making a change to not use dynamic containers if the jenkins server is ci.adoptium.net is probably the simplest solution here in the short term as that should be easy to determine.

@luhenry
Copy link
Contributor Author

luhenry commented Dec 21, 2023

Also, as discussed on the call this morning, the plan is to avoid using the dynamic pool, and instead queue up on our existing RISC-V boards. We would then not need to run inside a Docker container. Closing this PR until it's deemed necessary or better than current approach. Please ping me when/if any wants to discuss. Thanks!

@luhenry luhenry closed this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants