Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FIPS flag #5001

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Update FIPS flag #5001

merged 1 commit into from
Jan 24, 2024

Conversation

llxia
Copy link
Contributor

@llxia llxia commented Jan 24, 2024

  • change Jce to JCE
  • we will not rename the actual files.

related: backlog/issues/1322

Signed-off-by: Lan Xia <[email protected]>
@llxia
Copy link
Contributor Author

llxia commented Jan 24, 2024

Grinder

-Dsemeru.fips=true -Dsemeru.customprofile=OpenJCEPlusFIPS
...
excludes/dev/FIPS140_3_OpenJcePlusFIPS.jtx 

Grinder

-Dsemeru.fips=true -Dsemeru.customprofile=OpenJCEPlusFIPS
...
ProblemList-FIPS140_3_OpenJcePlus.txt

@llxia llxia marked this pull request as ready for review January 24, 2024 21:13
@llxia llxia requested review from JasonFengJ9 and pshipton January 24, 2024 21:13
Copy link
Contributor

@JasonFengJ9 JasonFengJ9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia
Copy link
Contributor Author

llxia commented Jan 24, 2024

Please ignore PR build results. It does not use personal repo (see issue #4855). Even if it uses the personal repo, my PR cannot be tested via PR builds. A special FIPS flag needs to be set for testing this PR.

@pshipton pshipton merged commit 722e00a into adoptium:master Jan 24, 2024
3 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants