Propagate JAVA_TOOL_OPTIONS down to external tests in container #5498
Conversation
Co-authored-by: Martijn Verburg <[email protected]>
|
I'm not sure why we need to pass the global Global one can be explicitly set by print_java_tool_options() |
|
JAVA_TOOL_OPTIONS is there to ensue, that you can orchestrate all your JVMs in same way. We use it eg to pass everywhere -XX+UseShenandoahGC and similar. BY not having it in contrainers means, that the JDK in container is tested differently then the jdsk on localhost. THis PR is removing this difference. If you will disaprove this, then a different way how to pass global settings down through container is needed |
On top of that - whatever will be implement to workaround this, is simply reimplementing wheel. because this is exactly what JAVA_TOOL_OPTIONS is for, and unless there is real strong reason to not forward it in, the not forwarding it should be considered as bug. |
|
That means tests will run with different JAVA_TOOL_OPTIONS on different environments but it's same for all other tests. Thanks @judovana |
| "\n" >> ${file} | ||
|
|
||
| echo -e "\nENV RANDFILE=/tmp/.rnd \\" \ | ||
| "\n\t OPENJ9_JAVA_OPTIONS=\"-XX:+IgnoreUnrecognizedVMOptions -XX:+IdleTuningGcOnIdle -Dosgi.checkConfiguration=false\" " \ | ||
| "\n\t OPENJ9_JAVA_OPTIONS=\"$OPENJ9_JAVA_OPTIONS -XX:+IgnoreUnrecognizedVMOptions -XX:+IdleTuningGcOnIdle -Dosgi.checkConfiguration=false\" " \ |
There was a problem hiding this comment.
Should this be $JAVA_TOOL_OPTIONS too?
There was a problem hiding this comment.
Merge now if need can be updated later.
Currently the external tests are swallowng the JAVA_TOOL_OPTIONS and thus the tested JDK does miss the global config. This pr should be fixing that