Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track all test materials or frameworks sha info #5818

Open
sophia-guo opened this issue Dec 12, 2024 · 2 comments · May be fixed by #5819
Open

Track all test materials or frameworks sha info #5818

sophia-guo opened this issue Dec 12, 2024 · 2 comments · May be fixed by #5819
Assignees

Comments

@sophia-guo
Copy link
Contributor

sophia-guo commented Dec 12, 2024

Part of #5759

Currently some repos ( TKG, openj9, aqa-tests and/or vendors shas) are checked by get.sh (https://github.com/search?q=repo%3Aadoptium%2Faqa-tests%20checkRepoSHA&type=code, which calls getSHA.sh in TKG), as those repos are visible when the get.sh is called.

Some repos are checked per test in build.xml (https://github.com/search?q=repo%3Aadoptium%2Faqa-tests+checkGitRepoSha&type=code, which calls macrodef in TKG, and then getSHA.sh in TKG)

Some repos sha are not checked and hence are missing in tap file. We could update each test build.xml as https://github.com/search?q=repo%3Aadoptium%2Faqa-tests+checkGitRepoSha&type=code. Though the solution feels more complicated when new tests material added. The collecting process is scattered across different places and different repo with each test needing to make the call. This approach is cumbersome and prone to being overlooked.

Suggestion to centralize the management of this process with the TKG framework can make it simpler and more convenient. Similar to testResultSummary, we can add a shaInfo target. This way collecting shas is invisible to aqa-tests hence no tests need to handle this itself.

@sophia-guo
Copy link
Contributor Author

@sophia-guo
Copy link
Contributor Author

@smlambert thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

1 participant