You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some repos sha are not checked and hence are missing in tap file. We could update each test build.xml as https://github.com/search?q=repo%3Aadoptium%2Faqa-tests+checkGitRepoSha&type=code. Though the solution feels more complicated when new tests material added. The collecting process is scattered across different places and different repo with each test needing to make the call. This approach is cumbersome and prone to being overlooked.
Suggestion to centralize the management of this process with the TKG framework can make it simpler and more convenient. Similar to testResultSummary, we can add a shaInfo target. This way collecting shas is invisible to aqa-tests hence no tests need to handle this itself.
The text was updated successfully, but these errors were encountered:
Part of #5759
Currently some repos ( TKG, openj9, aqa-tests and/or vendors shas) are checked by get.sh (https://github.com/search?q=repo%3Aadoptium%2Faqa-tests%20checkRepoSHA&type=code, which calls getSHA.sh in TKG), as those repos are visible when the get.sh is called.
Some repos are checked per test in build.xml (https://github.com/search?q=repo%3Aadoptium%2Faqa-tests+checkGitRepoSha&type=code, which calls macrodef in TKG, and then getSHA.sh in TKG)
Some repos sha are not checked and hence are missing in tap file. We could update each test build.xml as https://github.com/search?q=repo%3Aadoptium%2Faqa-tests+checkGitRepoSha&type=code. Though the solution feels more complicated when new tests material added. The collecting process is scattered across different places and different repo with each test needing to make the call. This approach is cumbersome and prone to being overlooked.
Suggestion to centralize the management of this process with the TKG framework can make it simpler and more convenient. Similar to testResultSummary, we can add a shaInfo target. This way collecting shas is invisible to aqa-tests hence no tests need to handle this itself.
The text was updated successfully, but these errors were encountered: