Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CropperWrapperComponent type is missing loading props #76

Open
jasongerbes opened this issue Sep 25, 2024 · 2 comments · May be fixed by #77
Open

CropperWrapperComponent type is missing loading props #76

jasongerbes opened this issue Sep 25, 2024 · 2 comments · May be fixed by #77

Comments

@jasongerbes
Copy link

The CropperWrapperComponent type is missing the following properties:

  • loading: boolean;
  • loaded: boolean;

These properties are used by the CropperWrapper.tsx component in react-mobile-cropper.
@jasongerbes
Copy link
Author

Looking at the git history, it appears these props have been deprecated.

image

As react-mobile-cropper is still using these deprecated properties, perhaps it should be updated to use cropper.isLoading() and cropper.isLoaded() instead.

@jasongerbes jasongerbes linked a pull request Sep 26, 2024 that will close this issue
Open
@jasongerbes
Copy link
Author

I've created a PR (see #77). The CropperWrapperComponent type is also missing disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing props to CropperWrapperComponent type jasongerbes/react-advanced-cropper
1 participant
@jasongerbes