Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template: Bulldog Magazine Article #88

Open
6 of 11 tasks
shirin27 opened this issue Feb 27, 2024 · 8 comments
Open
6 of 11 tasks

Template: Bulldog Magazine Article #88

shirin27 opened this issue Feb 27, 2024 · 8 comments

Comments

@shirin27
Copy link

shirin27 commented Feb 27, 2024

From vg-macktrucks-com-rd created by Gonzalo-CG: Netcentric/vg-macktrucks-com-rd#132

Business Value

As a content author, I want a quick way to create new articles from a template, so I don't have to add every component used on an article manually.

Description

A new "Bulldog Magazine Article" template will be available, which contains the basic structure and blocks that all Bulldog Magazine blog articles share.

The scope of this issue is to create the template, every block contained in this template has a separate issue for its development.

Acceptance Criteria

  • Magazine Article template is available for authors to use and is added to the AEM Sidekick library, which contains the basic structure and blocks that all Volvo Magazine Articles share.

  • To set the magazine article title, authors can type standalone text and format it as an H2 if the Magazine Hero block has a title defined, or as an H1 if the Magazine Hero block doesn't have a title defined.

  • The Magazine Article template contains all of the following elements (in a general order of priority):

    • aemsites/vg-macktrucks-com-old#766 (priority 1) Reflects the BE work needed. FE search will be implemented following https://github.com/hlxsites/vg-macktrucks-com-old/issues/913 otherwise the template can be created without search in the meantime.

    • aemsites/vg-macktrucks-com-old#746 (priority 2) Done

    • aemsites/vg-macktrucks-com-old#749 (priority 2) Done

    • aemsites/vg-macktrucks-com-old#750 (priority 2) Done

    • FR: Magazine Article layout #71 (priority 3) _Dependent on this ticket's completion.

    • aemsites/vg-macktrucks-com-old#748 (priority 3)Done

    • aemsites/vg-macktrucks-com-old#767 (priority 3) Done

  • To add the attribution and social block at the top of the page, a new variant of the v2 social block, named "attribution," will be created. The date and author information will be automatically pulled from the page's metadata.

Notes

Figma

Magazine Article - Figma.

Desktop:
Image

Mobile:
Image

@mollyaljenkins
Copy link
Collaborator

@WendyKruger Please notify us when the updates to the design have been done in Figma :) Thank you!

@mollyaljenkins mollyaljenkins added the Design Question RE/Dev team has open questions regarding the designs. label Apr 9, 2024
@BeckyMedlin
Copy link
Collaborator

@WendyKruger Is the Figma update ready yet?

@mollyaljenkins mollyaljenkins removed the Design Question RE/Dev team has open questions regarding the designs. label Jun 10, 2024
@mollyaljenkins mollyaljenkins self-assigned this Jun 26, 2024
@ZoeBeykirch ZoeBeykirch removed the 24B label Jun 26, 2024
@mollyaljenkins
Copy link
Collaborator

The last item that is holding this ticket is search related efforts.

@mollyaljenkins
Copy link
Collaborator

To be redetailed now that Search has been worked on for Magazines

@mollyaljenkins
Copy link
Collaborator

Estimate after all work is complete

@WendyKruger
Copy link
Collaborator

please make sure per issue #73 the styling for font size is also applied to the Mack-News template as well. the font size should be changed from 14px 16px on the news template.

@BeckyMedlin
Copy link
Collaborator

@mollyaljenkins https://github.com/hlxsites/vg-macktrucks-com/issues/754 needs to be completed after the template is created. Please update the description accordingly. Thank you!

@BeckyMedlin
Copy link
Collaborator

Questions:

  1. In what order should the blocks display in the template?
  2. Which block variants should be used for the template (ex: image banner, social block, pull quote have different ones)?
  3. Regarding the second AC: If every article is expected to have a hero block with a title, the page will already include an H1. If not, authors can simply type the H1 directly into the Word document. Pulling the title from metadata, removing the pipe character, and adding it to the page with JavaScript may be an unnecessary complexity. Removing this AC and having the H1 title included with the Hero block or typed in in H1, will reduce the story points for this ticket from 5 to 2 SP.
  4. "Subscribe (use existing block on production)."
    Does this refer to the magazine-subscribe block? If so, it's a v1 block, but in the designs, it appears to be a different block being used Authors using a v1 block on a template will get an error message for this

@alexiscoelho alexiscoelho transferred this issue from another repository Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

7 participants