Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Create [v2-Key-Facts] Block #12

Open
7 tasks
Tracked by #137
ZoeBeykirch opened this issue Oct 18, 2024 · 1 comment
Open
7 tasks
Tracked by #137

FR: Create [v2-Key-Facts] Block #12

ZoeBeykirch opened this issue Oct 18, 2024 · 1 comment
Assignees

Comments

@ZoeBeykirch
Copy link
Collaborator

ZoeBeykirch commented Oct 18, 2024

Context/Description

After investigating the issue with the Key Facts block reported in ticket https://github.com/hlxsites/vg-volvotrucks-us/issues/777#issuecomment-2418870267, the determined solution is to develop a dedicated [V2-key-facts] block to ensure that it is styled appropriately according to the v2 design specifications.

Acceptance Criteria

Editor AC:

  • Content editors can copy and paste the V2 Key Facts block from the Sidekick Library.
  • Content editors can use the block on any V2 redesign page.
  • Content editors can use this block with any of the colored backgrounds via metadata (black, grey, etc.)

Non-functional AC:

  • A new v2-key-facts block is created that adheres to the below Figma designs.
  • Video with auto-play can be used in the block.
  • Images can be used in the block.
  • The content makes use of available space as much as possible:

Note

Example of Key Facts block in production: https://www.volvotrucks.us/trucks/all-new-vnl/#powertrain

Attachment / link to Figma

Figma: https://www.figma.com/design/02CNUdjDefh83K5OeFx9PI/Volvo-Component-Library-C%26T?node-id=1675-142&t=wRJS5x0l1o9q5XNB-1

Desktop

Image

Mobile
image

Tablet
image

@AsmitKMishra
Copy link
Collaborator

Testing Completed. Feature works as expected and adheres to the Figma design.

santi-homps added a commit that referenced this issue Nov 27, 2024
@mollyaljenkins mollyaljenkins mentioned this issue Dec 3, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants