Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Add failsafe code when ACC_ENG_TRACKING is missing from the constants config #135

Open
5 tasks
mollyaljenkins opened this issue Nov 29, 2024 · 0 comments
Assignees

Comments

@mollyaljenkins
Copy link
Collaborator

mollyaljenkins commented Nov 29, 2024

Description

Add failsafe code when ACC_ENG_TRACKING is missing from the constants config so that pages where the config is not needed don't break if we remove the configuration entirely.

Steps to Reproduce

When ACC_ENG_TRACKING is missing the page will be broken.

Expected Results

  • The code doesn't break if the value is not present on the constants file
  • On the method extractObjectFromArray add a failsafe code to ensure that data is iterable
  • On the method formatStringToArray add a failsafe code to ensure that inputString is a string (and not undefined)
  • On the file /scripts/validate-elements.js ensure the code doens't break when TOOLS_CONFIGS is not set on the constants file
  • Remove all occurrences in all markets where the config is set but empty so the code doesn't break

Actual Results

The code breaks when the configuration is not present on the constants file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants