feat(revisions): adopt aep-162 revisions #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toumorokoshi
commented
Jul 11, 2024
toumorokoshi
commented
Jul 11, 2024
rofrankel
requested changes
Jul 11, 2024
rofrankel
reviewed
Aug 9, 2024
dv-stewarts
reviewed
Aug 13, 2024
toumorokoshi
force-pushed
the
yft/revisions
branch
from
c181b96 to
324aefc
Compare
Adapted from aip.dev/162. list of changes include: - changing references to "name" to "path". - minor formatting changes like consolidating proto examples so we can minimize the proto/openapi tabs. - removed some sections from rationale that spoke to aip.dev more than aeps, and didn't provide valuable context (like the existence of "tag" in older versions of the pattern). - added openapi schemas.
Co-authored-by: Richard Frankel <[email protected]>
Co-authored-by: Richard Frankel <[email protected]>
Co-authored-by: dv-stewarts <[email protected]>
rofrankel
requested changes
Sep 20, 2024
toumorokoshi
force-pushed
the
yft/revisions
branch
from
324aefc to
7ffc61d
Compare
Co-authored-by: Richard Frankel <[email protected]>
rofrankel
approved these changes
Sep 25, 2024
Co-authored-by: Richard Frankel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted from aip.dev/162.
list of changes include:
fixes #16.
🍱 Types of changes
What types of changes does your code introduce to AEP? Put an
xin the boxesthat apply
📋 Your checklist for this pull request
Please review the AEP Style and Guidance for
contributing to this repository.
General
references AEPs
correctly.
(usually
prettier -w .)Additional checklist for a new AEP
guidelines are met.
Document structure
guidelines are met.
💝 Thank you!