Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(standard-methods): clarify optional parent fields #252

Merged
merged 3 commits into from
Dec 14, 2024

Conversation

toumorokoshi
Copy link
Member

There is currently some inconsistency with the description of parent fields on standard methods, and whether they are required.

Clarifying that they are indeed optional, as the resource may not have a parent.

🍱 Types of changes

What types of changes does your code introduce to AEP? Put an x in the boxes
that apply

  • Enhancement
  • New proposal
  • Migrated from google.aip.dev
  • Chore / Quick Fix

📋 Your checklist for this pull request

Please review the AEP Style and Guidance for
contributing to this repository.

General

💝 Thank you!

There is currently some inconsistency with the description of
parent fields on standard methods, and whether they are required.

Clarifying that they are indeed optional, as the resource may
not have a parent.
@toumorokoshi toumorokoshi requested a review from a team as a code owner December 12, 2024 21:14
Copy link
Collaborator

@rofrankel rofrankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved modulo comments, and feel free to just fix the "and and" typo and merge if the other one isn't also some kind of typo.

aep/general/0132/aep.md.j2 Outdated Show resolved Hide resolved
aep/general/0132/aep.md.j2 Outdated Show resolved Hide resolved
@toumorokoshi toumorokoshi merged commit 2c182ee into aep-dev:main Dec 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants