Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not require aep resources have user-settable ids. #97

Open
toumorokoshi opened this issue Nov 1, 2024 · 2 comments
Open

do not require aep resources have user-settable ids. #97

toumorokoshi opened this issue Nov 1, 2024 · 2 comments

Comments

@toumorokoshi
Copy link
Member

the create API optionally supports the ID field, but the aep requires it. it should be categorized as a "should".

blocks aep-dev/aepc#39

see: https://github.com/aep-dev/aepc/actions/runs/11624260167/job/32372581247?pr=39

example/bookstore/v1/bookstore.proto:360:1:create methods should contain a singular `string id` field. (buf-plugin-aep)

contingent on aep-dev/aeps#222 merging.

@rambleraptor
Copy link
Member

This check is currently categorized as a "should", which means the check can be disabled by users.

There's two paths we have here:

  1. Remove the check from the linter altogether.
  2. Disable the check on your side.

What are your thoughts? Might be misunderstanding the ask.

@toumorokoshi
Copy link
Member Author

ack! thank you. Let me look at disabling the check on my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants