-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
several minor problems #8
Comments
First, thanks a lot for your input. icons: systemd: noxaarchup, aarchupstartup.example: messages: Thanks one more time :) |
systemd messages |
There is already a configuration file in /etc/aarchup.conf I will look into unifying all configuration to it.
For the messages, I will change it. AUR updates were only showing new version to keep output similar. But since pacman changed, no need to keep it like that. I guess I forgot to state that I was gonna change that on my previous message. One more time, thanks for the feedback and the detailed descriptions. |
But that's totally consistent with what I've been saying: any configuration file in /etc that's part of a package should be covered by "backup". |
I agree with you, that would be ideal. No idea when I will get around to do that though. |
This issue is meant to summarize a couple of problems which should be improved, imo, but which don't justify a bug report on their own.
All findings made with recent AUR package aarchup.
icons
The build procedure creates archlogo.svg but skips archlogo.png. If this is intentional (which I don't believe), aarchupstartup.example should be modified as it's referencing archlogo.png.
I think archlogo.{png,svg} should be placed in /usr/share/icons/hicolor/{32x32,scalable}/apps. This would be according to the Icon Theme Specification and hence make the icons available to other applications as well.
systemd
According to systemd documentation, see e. g. Section "Unit Load Path" in man (5) systemd.unit unit files provided by packages should go to /usr/lib/systemd/system. Folder /etc/systemd/system is for local configuration adjustments only, e. g. by copying units from /usr or by using those snippets in subfolders .service.d. So aarchup.{service,timer} should be moved accordingly.
As a side effect line backup in PKGBUILD wouldn't have to cover aarchup.timer any longer.
Regarding systemd.timer I think 15min is a bit much. Normally one wants to be informed as soon as possible after booting. So I'd suggest to reduce to 5min or something.
noxaarchup, aarchupstartup.example
noxaarchup is invoking aarchup without --icon. Would be nicer to have it set, imo.
Also, I think both noxaarchup and aarchupstartup.example should set --aur by default as using this switch when cower is lacking seems to cause nothing but an error message.
messages
Given Summary starts by "New updates..." setting "Application Name" to "New Updates" doesn't seem like a good choice to me, in particular with regards to notificationd implementations which state both items in their pop-ups like the one from LXQt. Why not set 'Application Name' just to 'aarchup'?
If updates in official repos are available both old and new version are displayed, regarding AUR only the latter. This should be consistent.
The text was updated successfully, but these errors were encountered: