-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tracing #79
Comments
See PR #80 |
We like this idea. We will put it in our next release, pending our testing of it |
Awesome! |
That's pretty cool, any plan to include this ? @shannonklaus ? |
Yes, I am still planning on including this at some point, it has been out prioritized by other features, but it is still on my radar |
Context
Tracing is a very powerful concept for modern backends and found its way as a basic of observability as logs and metrics are today.
In dotnet, distributed tracing was pushed forward in .NET 6 with the introduction of the
System.Diagnostics.Activity
APIs in the base class library.See this article and the official documentation.
Instrumentation was progressively introduced for the most common protocols over the last two years, starting with the
HttpClient
and following withGrpc.Net.Client
(see some example from the source code).Given the critical place Aerospike spike has in many backends, it would be more than welcome for this client to implement the
Activity
APIs.How
The
Activity
API is quite barebone and gives a lot of freedom as to how to use them. OpenTelemetry (part of the CNCF) proposes some naming conventions, which are already widely adopted by the industry (Grpc.Net.Client
uses them).Activity
whenever there is an I/O (in the case of retries, it means several Activities will be created).Activity.Current
usesAsyncLocal
. It's an important detail to understand how this API works under the hoodActivity
state must be marked as errorActivitySource.StartActivity(...)
will return null. That means that this won't affect performances in any way if there is no trace/listener ongoing (it will make no difference for people that don't use tracing)The text was updated successfully, but these errors were encountered: