Form2Daily Units Validation

[Patowhiz]

@smachua How should we handle validation of units on form2Daily entry form. Should the user be able to type in units that are not in the combobox? Upon entry of invalid units should the user be allowed to still save the records?

[mhabimana]

@Patowhiz I am testing the climsoft project on the AMI repository, Dev branch and found that on the FormDaily2,there is no units default when the form is opening. I suggest you add the default units as shown below instead of leaving this blank. Users will be able to decide whether to use the default units or choose different units from the drop down list:

Save and AddNew Buttons: on the Form Daily2 the button Save is not active when the formDaily2 table is empty but I can see AddNew is active (see below). This should be the reverse instead: Save button should be active and AddNew inactive when the FormDaily2 table is empty:

[Patowhiz]

@mhabimana the issues raised above have just been fixed. You can test that now

[mhabimana]

@Patowhiz : I can not see the change.Just forked the latest project shortly. Have you merged this?

[mhabimana]

@Patowhiz : Oh yes,I can see the change.Thanks

[mhabimana]

@Patowhiz: The default units (standard units) need to be fixed and the units textbox should not clear when clicking AddNew or save buttons or pressing at any key. This is exactly what is happening. When you open the form Daily2 for the first time or when you click on AddNew button, you see the standard units which is good but when you select the element or click AddNew again, the units disappear.

[mhabimana]

@Patowhiz , @maxwellfundi : Correction is needed on Form Daily 2 default Units,the default unit for clouds height is feet and not metre.

[Patowhiz]

@mhabimana that has now been fixed in the latest pull request. Thank you for checking on this

[mhabimana]

@Patowhiz :I am afraid,not sure if your changes took effect, because I am seing metre as default unit for clouds height instead of feet. Please,replace metre by feet under cloud height

[Patowhiz]

@mhabimana sorry I had not merged it before. I have now merged the pull request and this can now be tested