Merge pull request #31 from AgileBits/update-readme-source-code

Minor code and readme improvements.
agilebits · Aug 1, 2014 · 0ada237 · 0ada237
2 parents 4b65008 + 860f26e
commit 0ada237
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 6 deletions.
diff --git a/Demos/App Demo for iOS/App Demo for iOS/RegisterViewController.m b/Demos/App Demo for iOS/App Demo for iOS/RegisterViewController.m
@@ -49,21 +49,23 @@ - (IBAction)saveLoginTo1Password:(id)sender {
 		AppExtensionGeneratedPasswordMinLengthKey: @(6),
 		AppExtensionGeneratedPasswordMaxLengthKey: @(50)
 	};
+
 	__weak typeof (self) miniMe = self;
 
 	[[OnePasswordExtension sharedExtension] storeLoginForURLString:@"https://www.acme.com" loginDetails:newLoginDetails passwordGenerationOptions:passwordGenerationOptions forViewController:self completion:^(NSDictionary *loginDict, NSError *error) {
 
 		if (!loginDict) {
-			NSLog(@"Error invoking 1Password App Extension for generate password: %@", error);
+			NSLog(@"Failed to use 1Password App Extension to save a new Login: %@", error);
 			return;
 		}
 
 		__strong typeof(self) strongMe = miniMe;
 
-		strongMe.firstnameTextField.text = loginDict[AppExtensionReturnedFieldsKey][@"firstname"] ? : @"";
-		strongMe.lastnameTextField.text = loginDict[AppExtensionReturnedFieldsKey][@"lastname"] ? : @""
 		strongMe.usernameTextField.text = loginDict[AppExtensionUsernameKey] ? : @"";
 		strongMe.passwordTextField.text = loginDict[AppExtensionPasswordKey] ? : @"";
+		strongMe.firstnameTextField.text = loginDict[AppExtensionReturnedFieldsKey][@"firstname"] ? : @"";
+		strongMe.lastnameTextField.text = loginDict[AppExtensionReturnedFieldsKey][@"lastname"] ? : @""
+		// retrieve any additional fields that were passed in newLoginDetails dictionary
 	}];
 }
 

diff --git a/README.md b/README.md
@@ -148,14 +148,19 @@ Adding 1Password to your registration screen is very similar to adding 1Password
 	__weak typeof (self) miniMe = self;
 
 	[[OnePasswordExtension sharedExtension] storeLoginForURLString:@"https://www.acme.com" loginDetails:newLoginDetails passwordGenerationOptions:passwordGenerationOptions forViewController:self completion:^(NSDictionary *loginDict, NSError *error) {
+
 		if (!loginDict) {
-			NSLog(@"Error invoking 1Password App Extension for generate password: %@", error);
+			NSLog(@"Failed to use 1Password App Extension to save a new Login: %@", error);
 			return;
 		}
 
 		__strong typeof(self) strongMe = miniMe;
-		strongMe.usernameTextField.text = loginDict[AppExtensionUsernameKey] ? : strongMe.usernameTextField.text;
-		strongMe.passwordTextField.text = loginDict[AppExtensionPasswordKey] ? : strongMe.passwordTextField.text;
+
+		strongMe.usernameTextField.text = loginDict[AppExtensionUsernameKey] ? : @"";
+		strongMe.passwordTextField.text = loginDict[AppExtensionPasswordKey] ? : @"";
+		strongMe.firstnameTextField.text = loginDict[AppExtensionReturnedFieldsKey][@"firstname"] ? : @"";
+		strongMe.lastnameTextField.text = loginDict[AppExtensionReturnedFieldsKey][@"lastname"] ? : @""
+		// retrieve any additional fields that were passed in newLoginDetails dictionary
 	}];
 }
 ```