Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying a segment of the payload for produce #81

Closed
MaximGurschi opened this issue Nov 16, 2016 · 4 comments
Closed

Allow specifying a segment of the payload for produce #81

MaximGurschi opened this issue Nov 16, 2016 · 4 comments

Comments

@MaximGurschi
Copy link
Contributor

Hello Andreas,

Would you consider a pull request that allows specifying a segment of the payload bytes to send?
This is to avoid buffer copying. It will require some unsafe code though.

@ah-
Copy link
Owner

ah- commented Nov 16, 2016

Good timing. There was/is a PR implementing exactly that: https://github.com/ah-/rdkafka-dotnet/pull/79 and https://github.com/ah-/rdkafka-dotnet/pull/73

I'll have a look as soon as a find some time, if you test it it'll certainly go in quicker.

@MaximGurschi
Copy link
Contributor Author

Happy to test.

@MaximGurschi
Copy link
Contributor Author

Are you waiting for me to test the PR before implementing this?

@ah-
Copy link
Owner

ah- commented Dec 1, 2016

Hi, I'm just waiting to have some time to do some minimal sanity checks. If you have time please test, that'll speed things up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants