Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused normalization code leftover in fv3fit #2092

Open
7 tasks
frodre opened this issue Oct 12, 2022 · 0 comments
Open
7 tasks

Unused normalization code leftover in fv3fit #2092

frodre opened this issue Oct 12, 2022 · 0 comments
Assignees
@frodre

Comments

@frodre
Copy link
Contributor

frodre commented Oct 12, 2022

There is a deprecated module fv3fit.emulation.layers.normalization that is confusing, no longer really used, and should be removed.

Steps for resolving:

  • Adjust jacobian to use std methods from normalize2
  • Adjust jacobian tests to use std methods from normalize2
  • Adjust train_microphysics to use std methods for jacobian for normalize2
  • Move the key_to_norm2_factory in normalization into normalize2
  • Adjusts the test_fields.py to use the moved key_to_norm2_factory
  • Delete normalization
  • Rename normalization2 to normalization
@frodre frodre self-assigned this Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frodre frodre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@frodre