Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radiation port lacks a regression test #2389

Open
brianhenn opened this issue Jan 23, 2024 · 0 comments
Open

Radiation port lacks a regression test #2389

brianhenn opened this issue Jan 23, 2024 · 0 comments

Comments

@brianhenn
Copy link
Contributor

Since the deletion of the serialized fv3gfs-fortran data that supported the regression test of the python port of the radiation code, the port lacks a functioning regression test. That test was brittle and had high overhead because it depended on reading serialbox-generated data, so replacing it with a python-only test using the current code makes sense anyway. One challenge will be how to make a regression test for the stochastic MCICA radiation scheme -- the prior test actually serialized all of the random numbers, which might be difficult to reimplement. Instead we could port a deterministic (non-MC) option that already exists in the Fortran version and test that, or we could just test the deterministic clear sky part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant