Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cookiecutter questions #10

Closed
IgnacioHeredia opened this issue Aug 27, 2024 · 4 comments
Closed

Update Cookiecutter questions #10

IgnacioHeredia opened this issue Aug 27, 2024 · 4 comments
Assignees

Comments

@IgnacioHeredia
Copy link
Contributor

Now that everything will be hosted under ai4os-hub I don't think it makes sense to keep showing users the git_base_url parameter. We can keep having it as a hidden variable though.

I also think something similar for app_version. If you are creating the template you would want always the version to be 0.0.1 right? Does it make sense to be configurable?

Finally, I will add to the help message of project_name that it is the name of the python module. Otherwise, people tend to use very lengthy names that look ugly.

@vykozlov
Copy link
Contributor

+1 for "ai4o-hub" and git_base_url
for "app_version", I would keep it configurable, someone may consider their version not "0.0.1" if the certain code already existed
to be on the safe side, I put that tin to-do :-)

@BorjaEst
Copy link
Contributor

BorjaEst commented Oct 1, 2024

Note also
ai4os/ai4-template-adv#6

@BorjaEst
Copy link
Contributor

BorjaEst commented Oct 8, 2024

git_base_url is now "private" so we can change it easily in the future
project_name prompt updated

I leave this open till we decide how to implement the tags in the template

@vykozlov
Copy link
Contributor

vykozlov commented Oct 9, 2024

I think, we can close this issue but @BorjaEst , please, have a look to #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants